Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1350310

Re: pull-request: wireless-drivers 2016-02-18

Show all headers | View raw

(Adding Larry)

Geert Uytterhoeven <geert@linux-m68k.org> writes:

> On Thu, Feb 18, 2016 at 4:28 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
>
>> rtlwifi
>>
>> * fix broken VHT (802.11ac) support, reported by Linus
>
> That's commit d76d65fd26951498144029c24852c4d54ee512d9
>
> drivers/net/wireless/realtek/rtlwifi/rc.c: In function
> ‘_rtl_rc_rate_set_series’:
> drivers/net/wireless/realtek/rtlwifi/rc.c:144: warning: comparison is
> always false due to limited range of data type
>
>                 if (sta && sta->vht_cap.vht_supported &&
>                     (wireless_mode == WIRELESS_MODE_AC_5G ||
>                      wireless_mode == WIRELESS_MODE_AC_24G ||
>                      wireless_mode == WIRELESS_MODE_AC_ONLY))
>                         rate->flags |= IEEE80211_TX_RC_VHT_MCS;
>
> u8 wireless_mode = 0;
>
> enum wireless_mode {
>         ...
>         WIRELESS_MODE_AC_ONLY = 0x100,
>
> How is that supposed to work?

I have no idea what could be the difference, for example, between AC_5G
and AC_ONLY. Maybe AC_ONLY mode is not really used in normal setups and
that's why the bug doesn't break anything? Larry, do you know?

Anyway, Larry has a patch for this but I'm planning to send it to 4.6 as
I didn't think it as that urgent:

rtlwifi: Fix size of wireless mode variable

https://patchwork.kernel.org/patch/8425191/

-- 
Kalle Valo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: pull-request: wireless-drivers 2016-02-18 Geert Uytterhoeven <geert@linux-m68k.org> - 2016-02-29 09:40 +0100
  Re: pull-request: wireless-drivers 2016-02-18 Kalle Valo <kvalo@codeaurora.org> - 2016-03-04 16:30 +0100
    Re: pull-request: wireless-drivers 2016-02-18 Larry Finger <Larry.Finger@lwfinger.net> - 2016-03-04 18:20 +0100

csiph-web