Re: [RFC] Re: [PATCHSET 0/8] perf tools: Support multiple keys in a single hierarchy level (v1)

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC] Re: [PATCHSET 0/8] perf tools: Support multiple keys in a single hierarchy level (v1)
Date	2016-03-04 14:40 +0100
Message-ID	<r8Y7v-7tk-3@gated-at.bofh.it> (permalink)
References	<r8hFg-1CS-9@gated-at.bofh.it> <r8hOY-1I2-51@gated-at.bofh.it> <r8odH-6BT-3@gated-at.bofh.it> <r8BaW-7xs-11@gated-at.bofh.it> <r8LjY-6lK-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Fri, Mar 04, 2016 at 08:50:51AM +0900, Namhyung Kim escreveu:
> On Thu, Mar 03, 2016 at 10:08:15AM -0300, Arnaldo Carvalho de Melo wrote:
> > We should try to use tokens that already have some strong meaning
> > associated to them instead of using those that are more easily
> > available, otherwise our mumbo jumbo will grow even more unwieldly 8-/

> > In fact I think that in this case we could even make it look more like
> > natural languages and use:

> >   perf report --hierarchy -s 'prev_pid,prev_comm;next_pid,next_comm'

> > To ask for:

> >       prev_pid  prev_comm
> >             next_pid  next_comm          
> >       - 1234      bash
> >               5678     firefox
> >       + 8912      hexchat

> > I.e. if ';' is present, it is the separator for each hierarchy level,
> > with ',' being used for stating the per-hierarchy level fields.

> If it's not a common operation and we have used '{ }' for the event
> groups, why not using it here too?

>   $ perf report --hierarchy -s '{prev_pid,prev_comm},{next_pid,next_comm}'

> It's more verbose but more intuitive IMHO.

Right, we would be using {} consistently as a way of grouping entities.

I'm fine with that.

- Arnaldo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHSET 0/8] perf tools: Support multiple keys in a single hierarchy level (v1) Namhyung Kim <namhyung@kernel.org> - 2016-03-02 17:20 +0100
  [PATCH 1/8] perf tools: Add level field to struct perf_hpp_fmt Namhyung Kim <namhyung@kernel.org> - 2016-03-02 17:20 +0100
  [PATCH 3/8] perf tools: Use own hpp_list for hierarchy mode Namhyung Kim <namhyung@kernel.org> - 2016-03-02 17:20 +0100
  [PATCH 6/8] perf report: Use hierarchy hpp list on stdio Namhyung Kim <namhyung@kernel.org> - 2016-03-02 17:20 +0100
  [PATCH 7/8] perf hists browser: Use hierarchy hpp list Namhyung Kim <namhyung@kernel.org> - 2016-03-02 17:20 +0100
  [PATCH 2/8] perf tools: Introduce perf_hpp__setup_hists_formats() Namhyung Kim <namhyung@kernel.org> - 2016-03-02 17:20 +0100
    Re: [PATCH 2/8] perf tools: Introduce perf_hpp__setup_hists_formats() Jiri Olsa <jolsa@redhat.com> - 2016-03-03 14:50 +0100
      Re: [PATCH 2/8] perf tools: Introduce perf_hpp__setup_hists_formats() Namhyung Kim <namhyung@kernel.org> - 2016-03-04 01:00 +0100
    Re: [PATCH 2/8] perf tools: Introduce perf_hpp__setup_hists_formats() Jiri Olsa <jolsa@redhat.com> - 2016-03-03 14:50 +0100
      Re: [PATCH 2/8] perf tools: Introduce perf_hpp__setup_hists_formats() Namhyung Kim <namhyung@kernel.org> - 2016-03-04 01:00 +0100
  Re: [PATCHSET 0/8] perf tools: Support multiple keys in a single  hierarchy level (v1) Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-03-02 17:30 +0100
    Re: [PATCHSET 0/8] perf tools: Support multiple keys in a single  hierarchy level (v1) Namhyung Kim <namhyung@kernel.org> - 2016-03-03 00:20 +0100
      [RFC] Re: [PATCHSET 0/8] perf tools: Support multiple keys in a  single hierarchy level (v1) Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-03-03 14:10 +0100
        Re: [RFC] Re: [PATCHSET 0/8] perf tools: Support multiple keys in a  single hierarchy level (v1) Namhyung Kim <namhyung@kernel.org> - 2016-03-04 01:00 +0100
          Re: [RFC] Re: [PATCHSET 0/8] perf tools: Support multiple keys in a  single hierarchy level (v1) Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-03-04 14:40 +0100

csiph-web