Re: [PATCH v4 0/4] ACPI: parse the SPCR table

From	Aleksey Makarov <aleksey.makarov@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 0/4] ACPI: parse the SPCR table
Date	2016-03-04 13:00 +0100
Message-ID	<r8WyK-69A-9@gated-at.bofh.it> (permalink)
References	<r7uOd-2PD-5@gated-at.bofh.it> <r7Uz0-2wf-5@gated-at.bofh.it> <r8AeS-6Vw-11@gated-at.bofh.it> <r8Dw6-Di-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 03/03/2016 06:35 PM, Peter Hurley wrote:
> On 03/03/2016 03:59 AM, Aleksey Makarov wrote:
>>
>>
>> On 03/01/2016 06:31 PM, Peter Hurley wrote:
>>> On 02/29/2016 04:02 AM, Aleksey Makarov wrote:
>>>> 'ARM Server Base Boot Requirements' [1] mentions SPCR (Serial Port
>>>> Console Redirection Table) [2] as a mandatory ACPI table that
>>>> specifies the configuration of serial console.
>>>>
>>>> Introduce a new function acpi_console_check().  At the uart port
>>>> registration, this function checks if the ACPI SPCR table specifies
>>>> its argument of type struct uart_port to be a console
>>>> and if so calls add_preferred_console().
>>>
>>> How will a user enable an earlycon on the same console as the SPCR
>>> console if there is no DBG2 table?
>>
>> ...
>> [    0.000000] earlycon: pl11 at MMIO 0x0000000009000000 (options '')
>> [    0.000000] bootconsole [pl11] enabled
>> ...
>> [    0.000000] Kernel command line:  root=/dev/vda1 rw systemd.show_status=no acpi=force earlycon=pl011,0x9000000
>> ...
>> [    0.318248] ACPI: SPCR: adding preferred console [ttyAMA0]
>> [    0.318736] ARMH0011:00: ttyAMA0 at MMIO 0x9000000 (irq = 5, base_baud = 0) is a SBSA
>> [    0.319502] console [ttyAMA0] enabled
>> [    0.319502] console [ttyAMA0] enabled
>> [    0.319933] bootconsole [pl11] disabled
>> [    0.319933] bootconsole [pl11] disabled
>> ...
>>
>> Why?
> 
> That's pretty disingenuous; via command line?
> 
> By that measure, none of your patches are required because a user
> can already start both console and earlycon without them.
> 
> With the console location specified in the SPCR, earlycon should
> be opt-in on the command-line simply with "earlycon" command-line
> parameter.

Yes.  That's why we have SPCR *and* DBG2. 
DBG2 specifies where we should run earlycon.

>>> How will a user enable an earlycon on the same console as the SPCR
>>> console if there is no DBG2 table?

In no way.  You need DBG2 to run earlycon.

(If you don't want to specify it's address etc explicitly)

Thread

[PATCH v4 0/4] ACPI: parse the SPCR table Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-02-29 13:10 +0100
  [PATCH v4 1/4] ACPI: parse SPCR and enable matching console Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-02-29 13:10 +0100
    Re: [PATCH v4 1/4] ACPI: parse SPCR and enable matching console Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-29 14:40 +0100
      Re: [PATCH v4 1/4] ACPI: parse SPCR and enable matching console Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-02-29 15:00 +0100
  [PATCH v4 3/4] ACPI: add definitions of DBG2 subtypes Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-02-29 13:10 +0100
  Re: [PATCH v4 0/4] ACPI: parse the SPCR table Peter Hurley <peter@hurleysoftware.com> - 2016-03-01 16:30 +0100
  Re: [PATCH v4 0/4] ACPI: parse the SPCR table Peter Hurley <peter@hurleysoftware.com> - 2016-03-01 16:40 +0100
    Re: [PATCH v4 0/4] ACPI: parse the SPCR table Aleksey Makarov <amakarov.linux@gmail.com> - 2016-03-03 13:10 +0100
      Re: [PATCH v4 0/4] ACPI: parse the SPCR table Peter Hurley <peter@hurleysoftware.com> - 2016-03-03 16:40 +0100
        Re: [PATCH v4 0/4] ACPI: parse the SPCR table Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-03-04 13:00 +0100
          Re: [PATCH v4 0/4] ACPI: parse the SPCR table Peter Hurley <peter@hurleysoftware.com> - 2016-03-04 16:50 +0100
            Re: [PATCH v4 0/4] ACPI: parse the SPCR table Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-03-11 17:30 +0100

csiph-web