Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1350147

[PATCH] parport: register driver later

Show all headers | View raw

If the parport bus is not yet registered and any device using parallel
port tries to register with the bus we get a stackdump with a message
of Kernel bug.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Tested-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: <stable@vger.kernel.org> # 4.2+ 
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---

We should actually have some deferred probe here. But considering that
you will be closing your trees soon so a quick fix to solve the problem
for now. We will revisit this when we remove the old api (hopefully v4.7).

 drivers/parport/share.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/parport/share.c b/drivers/parport/share.c
index 3308427..176b2b6 100644
--- a/drivers/parport/share.c
+++ b/drivers/parport/share.c
@@ -273,6 +273,9 @@ int __parport_register_driver(struct parport_driver *drv, struct module *owner,
 		/* using device model */
 		int ret;
 
+		if (!parport_bus_type.p)
+			return -EAGAIN;
+
 		/* initialize common driver fields */
 		drv->driver.name = drv->name;
 		drv->driver.bus = &parport_bus_type;
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] parport: register driver later Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-04 12:00 +0100
  Re: [PATCH] parport: register driver later Greg KH <gregkh@linuxfoundation.org> - 2016-03-05 21:20 +0100
    Re: [PATCH] parport: register driver later Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-06 19:00 +0100
      Re: [PATCH] parport: register driver later Greg KH <gregkh@linuxfoundation.org> - 2016-03-07 02:20 +0100

csiph-web