Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1350006
| From | Jiri Slaby <jslaby@suse.cz> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3.12 100/116] hwmon: (ads1015) Handle negative conversion values correctly |
| Date | 2016-03-04 10:20 +0100 |
| Message-ID | <r8U3W-4v0-49@gated-at.bofh.it> (permalink) |
| References | <r8TUd-4rg-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Peter Rosin <peda@axentia.se> 3.12-stable review patch. If anyone has any objections, please let me know. =============== commit acc146943957d7418a6846f06e029b2c5e87e0d5 upstream. Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative dividends when the divisor is unsigned. Signed-off-by: Peter Rosin <peda@axentia.se> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Jiri Slaby <jslaby@suse.cz> --- drivers/hwmon/ads1015.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c index 126516414c11..44223f5d92d8 100644 --- a/drivers/hwmon/ads1015.c +++ b/drivers/hwmon/ads1015.c @@ -126,7 +126,7 @@ static int ads1015_reg_to_mv(struct i2c_client *client, unsigned int channel, struct ads1015_data *data = i2c_get_clientdata(client); unsigned int pga = data->channel_data[channel].pga; int fullscale = fullscale_table[pga]; - const unsigned mask = data->id == ads1115 ? 0x7fff : 0x7ff0; + const int mask = data->id == ads1115 ? 0x7fff : 0x7ff0; return DIV_ROUND_CLOSEST(reg * fullscale, mask); } -- 2.7.2
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 3.12 100/116] hwmon: (ads1015) Handle negative conversion values correctly Jiri Slaby <jslaby@suse.cz> - 2016-03-04 10:20 +0100
csiph-web