[PATCH] tmpfs: shmem_fallocate must return ERESTARTSYS

From	Maxim Patlasov <mpatlasov@virtuozzo.com>
Newsgroups	linux.kernel
Subject	[PATCH] tmpfs: shmem_fallocate must return ERESTARTSYS
Date	2016-03-04 01:40 +0100
Message-ID	<r8LWF-6Q3-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

shmem_fallocate() is restartable, so it can return ERESTARTSYS if
signal_pending(). Although fallocate(2) manpage permits EINTR,
the more places use ERESTARTSYS the better.

Signed-off-by: Maxim Patlasov <mpatlasov@virtuozzo.com>
---
 mm/shmem.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index 440e2a7..60e9c8a 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -2229,11 +2229,13 @@ static long shmem_fallocate(struct file *file, int mode, loff_t offset,
 		struct page *page;
 
 		/*
-		 * Good, the fallocate(2) manpage permits EINTR: we may have
-		 * been interrupted because we are using up too much memory.
+		 * Although fallocate(2) manpage permits EINTR, the more
+		 * places use ERESTARTSYS the better. If we have been
+		 * interrupted because we are using up too much memory,
+		 * oom-killer used fatal signal and we will die anyway.
 		 */
 		if (signal_pending(current))
-			error = -EINTR;
+			error = -ERESTARTSYS;
 		else if (shmem_falloc.nr_unswapped > shmem_falloc.nr_falloced)
 			error = -ENOMEM;
 		else

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] tmpfs: shmem_fallocate must return ERESTARTSYS Maxim Patlasov <mpatlasov@virtuozzo.com> - 2016-03-04 01:40 +0100
  Re: [PATCH] tmpfs: shmem_fallocate must return ERESTARTSYS Mike Kravetz <mike.kravetz@oracle.com> - 2016-03-04 01:50 +0100

csiph-web