Re: [PATCH] of: add 'const' for of_property__string() parameter '*np'

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] of: add 'const' for of_property__string() parameter '*np'
Date	2016-03-04 00:00 +0100
Message-ID	<r8KnT-5IL-5@gated-at.bofh.it> (permalink)
References	<r8mEX-5rx-7@gated-at.bofh.it> <r8BXl-7Qj-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 03, 2016 at 07:52:51AM -0600, Rob Herring wrote:
> On Wed, Mar 2, 2016 at 3:35 PM, David Rivshin (Allworx)
> <drivshin.allworx@gmail.com> wrote:
> > From: David Rivshin <drivshin@allworx.com>
> >
> > The of_property_{read,count,match}_string* family of functions never
> > modify the struct device_node pointer that is passed in, so there is no
> > reason for it to be non-const. Equivalent functions for all other types
> > already take a 'const struct device_node *np'.
> >
> > Signed-off-by: David Rivshin <drivshin@allworx.com>
> > ---
> >
> > MAINTAINTERS says that the appropriate tree is
> >     git://git.kernel.org/pub/scm/linux/kernel/git/glikely/linux.git
> 
> Yes, we probably need to update that.
> 
> > but it looks like that hasn't been updated in a while. So this patch
> > is based off the "for-next" branch of
> >     git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
> > instead. Let me know if you need me to respin from another tree/branch.
> 
> You should base off of Linus' tree unless you have some dependency. I
> doubt it matters in this case, so no need to resend.

And now applied.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] of: add 'const' for of_property_*_string*() parameter '*np' "David Rivshin (Allworx)" <drivshin.allworx@gmail.com> - 2016-03-02 22:40 +0100
  Re: [PATCH] of: add 'const' for of_property_*_string*() parameter '*np' Rob Herring <robh+dt@kernel.org> - 2016-03-03 15:00 +0100
    Re: [PATCH] of: add 'const' for of_property_*_string*() parameter  '*np' "David Rivshin (Allworx)" <drivshin.allworx@gmail.com> - 2016-03-03 23:20 +0100
      Re: [PATCH] of: add 'const' for of_property_*_string*() parameter '*np' Rob Herring <robh+dt@kernel.org> - 2016-03-04 01:20 +0100
    Re: [PATCH] of: add 'const' for of_property_*_string*() parameter  '*np' Rob Herring <robh@kernel.org> - 2016-03-04 00:00 +0100

csiph-web