Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1349596

[PATCH] x86: PAT: Documentation: update overlapping ioremap hack recommendation

Show key headers only | View raw

The current documentation refers to using set_memor_wc() as a
possible hole strategy when you have overlapping ioremap() regions,
that's incorrect as set_memory_*() helpers can only be used on RAM,
not IO memory. This fixes that, and updates the documention to
*strongly* discourage overlapping ioremap() memory uses, but also
documents a possible solution should there really be no other
option.

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 Documentation/x86/pat.txt | 25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/Documentation/x86/pat.txt b/Documentation/x86/pat.txt
index 54944c71b819..8a26b4cdccf6 100644
--- a/Documentation/x86/pat.txt
+++ b/Documentation/x86/pat.txt
@@ -113,18 +113,21 @@ MTRR effects on PAT / non-PAT systems
 -------------------------------------
 
 The following table provides the effects of using write-combining MTRRs when
-using ioremap*() calls on x86 for both non-PAT and PAT systems. Ideally
-mtrr_add() usage will be phased out in favor of arch_phys_wc_add() which will
-be a no-op on PAT enabled systems. The region over which a arch_phys_wc_add()
+using ioremap*() calls on x86 for both non-PAT and PAT systems. As of v4.3
+mtrr_add() has been phased out in favor of arch_phys_wc_add(), these calls are
+a no-op on PAT enabled systems. The region over which an arch_phys_wc_add()
 is made, should already have been ioremapped with WC attributes or PAT entries,
-this can be done by using ioremap_wc() / set_memory_wc().  Devices which
-combine areas of IO memory desired to remain uncacheable with areas where
-write-combining is desirable should consider use of ioremap_uc() followed by
-set_memory_wc() to white-list effective write-combined areas.  Such use is
-nevertheless discouraged as the effective memory type is considered
-implementation defined, yet this strategy can be used as last resort on devices
-with size-constrained regions where otherwise MTRR write-combining would
-otherwise not be effective.
+this can be done by using ioremap_wc(). Devices which combine areas of IO
+memory desired to remain uncacheable with areas where write-combining is
+desirable should consider use of ioremap_wc() followed by an overlapping
+ioremap_uc() "hole". For an example of this strategy refer to commit 3cc2dac5be
+("drivers/video/fbdev/atyfb: Replace MTRR UC hole with strong UC").
+Such use is nevertheless heavily discouraged as the effective memory type is
+considered implementation defined. This strategy should only be used used as a
+last resort measure.
+
+Note you cannot use set_memory_*() helpers on ioremap'd regions, even though
+its use currently gives no hint of an error.
 
 ----------------------------------------------------------------------
 MTRR Non-PAT   PAT    Linux ioremap value        Effective memory type
-- 
2.7.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86: PAT: Documentation: update overlapping ioremap hack recommendation "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-03-03 22:30 +0100
  Re: [PATCH] x86: PAT: Documentation: update overlapping ioremap hack  recommendation "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-03-03 22:50 +0100
    Re: [PATCH] x86: PAT: Documentation: update overlapping ioremap hack  recommendation "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-03-04 20:30 +0100
      Re: [PATCH] x86: PAT: Documentation: update overlapping ioremap hack  recommendation "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-03-04 22:10 +0100
        [PATCH v2] x86: PAT: Documentation: rewrite "MTRR effects on PAT / non-PAT systems" "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-03-04 23:50 +0100
          Re: [PATCH v2] x86: PAT: Documentation: rewrite "MTRR effects on PAT  / non-PAT systems" "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-03-05 01:10 +0100
            Re: [PATCH v2] x86: PAT: Documentation: rewrite "MTRR effects on PAT  / non-PAT systems" "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-03-05 02:10 +0100
          RE: [PATCH v2] x86: PAT: Documentation: rewrite "MTRR effects on  PAT / non-PAT systems" "Elliott, Robert (Persistent Memory)" <elliott@hpe.com> - 2016-03-05 05:50 +0100
            Re: [PATCH v2] x86: PAT: Documentation: rewrite "MTRR effects on PAT  / non-PAT systems" "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-03-15 23:30 +0100
          Re: [PATCH v2] x86: PAT: Documentation: rewrite "MTRR effects on PAT  / non-PAT systems" Ingo Molnar <mingo@kernel.org> - 2016-03-05 13:00 +0100
            Re: [PATCH v2] x86: PAT: Documentation: rewrite "MTRR effects on PAT  / non-PAT systems" "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-03-15 23:30 +0100

csiph-web