Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1349582

Re: [GIT PULL] Block fixes for 4.5-final

Show all headers | View raw

On Thu, Mar 3, 2016 at 12:57 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Feel free to resend the parts that are actually critical, but explain
> exactly why they are so critical when you do.

Just to clarify: anything that contains "lightnvm" is definitely not
critical enough. Are there even any users? I'm done seeing these
constant large lightnvm patches.

NVMe is certainly a lot more important, but if it's about hot unplug
that has never been reliable before, or about cleaning up the reset
sequence by avoiding unmapping the register space, I really don't see
what makes those critical patches that should go in outside of the
merge window.

So no more of this "several hundred lines of random code changes after
rc6 for issues that aren't fixing an actual critical bug and has never
worked before either".

The block pull request was literally three times the size of all the
other (*seven*) pull requests I've done today that were actually small
fixes. Yeah, I'm not going to say that all of those were necessarily
truly critical either, but at least they were very small and clearly
fixes, and several of them fixed things like actual BUG_ON's or boot
hangs.

                    Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL] Block fixes for 4.5-final Jens Axboe <axboe@fb.com> - 2016-03-03 18:30 +0100
  Re: [GIT PULL] Block fixes for 4.5-final Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-03 22:00 +0100
    Re: [GIT PULL] Block fixes for 4.5-final Jens Axboe <axboe@kernel.dk> - 2016-03-03 22:20 +0100
    Re: [GIT PULL] Block fixes for 4.5-final Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-03 22:20 +0100
    Re: [GIT PULL] Block fixes for 4.5-final Jens Axboe <axboe@fb.com> - 2016-03-03 22:20 +0100
      Re: [GIT PULL] Block fixes for 4.5-final Jens Axboe <axboe@fb.com> - 2016-03-03 22:30 +0100
        Re: [GIT PULL] Block fixes for 4.5-final Jens Axboe <axboe@fb.com> - 2016-03-03 23:00 +0100
      Re: [GIT PULL] Block fixes for 4.5-final Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-03 22:30 +0100

csiph-web