Re: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing

From	Stephen Warren <swarren@wwwdotorg.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing
Date	2016-03-03 22:10 +0100
Message-ID	<r8IFs-4uo-3@gated-at.bofh.it> (permalink)
References	<r7Hs5-2lK-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/29/2016 06:30 PM, Eric Anholt wrote:
> From: Phil Elwell <phil@raspberrypi.org>
>
> The DT bindings for pinctrl-bcm2835 allow both the function and pull
> to contain either one entry or one per pin. However, an error in the
> DT parsing can cause failures if the number of pulls differs from the
> number of functions.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Cc: stable@vger.kernel.org
> ---
>
> Yes, the s-o-b differs from the author of the commit, but this falls
> under part b) of the process.

I'd argue that part (b) only applies if the s-o-b line is present in the 
original, otherwise I'm not sure how it's clear the author intended to 
publish their source under the license in question. That's why I've 
always beedn careful to go back and ask the original author to give 
their s-o-b, like you did. Some commits at least in the earlier Pi 
Foundation kernels also clearly had incorrect git author values, or were 
squashed together forms of multiple peoples' work:-(

Luckily it's a moot point since Phil gave his s-o-b.

Reviewed-by: Stephen Warren <swarren@wwwdotorg.org>

Does a similar bug exist in any other pinctrl drivers?

Thread

[PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing Eric Anholt <eric@anholt.net> - 2016-03-01 02:40 +0100
  Re: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull"  parsing Phil Elwell <phil@raspberrypi.org> - 2016-03-01 10:20 +0100
  Re: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull"  parsing Stephen Warren <swarren@wwwdotorg.org> - 2016-03-03 22:10 +0100
  Re: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing Linus Walleij <linus.walleij@linaro.org> - 2016-03-08 09:20 +0100

csiph-web