Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1349307

Re: [PATCH] [v4] x86, pkeys: fix siginfo ABI breakage from new field

Show all headers | View raw

* Dave Hansen <dave@sr71.net> wrote:

> To fix this, we replace the u64 with an '__u32'.  The __u32 is guaranteed to 
> union well with the pointers from _addr_bnd.  It is also plenty large enough to 
> store the 16-bit pkey we have today on x86.

The 'union well' sentence is really a leftover from the earlier changelog (the 
problem was never about interaction between union members) - a better explantion 
is:

> To fix this, we replace the u64 with an '__u32'.  The __u32 does not change the 
> minimum alignment requirements of the structure and it is also plenty large 
> enough to store the 16-bit pkey we have today on x86.

I fixed this up locally, no need to resend.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [v4] x86, pkeys: fix siginfo ABI breakage from new field Dave Hansen <dave@sr71.net> - 2016-03-01 14:00 +0100
  Re: [PATCH] [v4] x86, pkeys: fix siginfo ABI breakage from new field Ingo Molnar <mingo@kernel.org> - 2016-03-03 16:50 +0100
  [tip:mm/pkeys] mm/pkeys: Fix siginfo ABI breakage caused by new u64  field tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-03-03 18:00 +0100
    Re: [tip:mm/pkeys] mm/pkeys: Fix siginfo ABI breakage caused by new  u64 field Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-03 18:30 +0100

csiph-web