Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1349266

Re: [PATCH] staging/android: refactor SYNC_IOC_FILE_INFO

Show all headers | View raw

Op 03-03-16 om 15:34 schreef Gustavo Padovan:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> Change SYNC_IOC_FILE_INFO behaviour to avoid future API breaks and
> optimize buffer
>
> Now num_fences can be filled by the caller to inform how many fences it
> wants to retrieve from the kernel. If the num_fences passed is greater
> than zero info->sync_fence_info should point to a buffer with enough space
> to fit all fences.
>
> However if num_fences passed to the kernel is 0, the kernel will reply
> with number of fences of the sync_file.
>
> Sending first an ioctl with num_fences = 0 can optimize buffer allocation,
> in a first call with num_fences = 0 userspace will receive the actual
> number of fences in the num_fences filed.
>
> Then it can allocate a buffer with the correct size on sync_fence_info and
> call SYNC_IOC_FILE_INFO again, but now with the actual value of num_fences
> in the sync_file.
>
> Also, info->sync_fence_info was converted to __u64 pointer to prevent
> 32bit compatibility issues.
For this patch and 6/6:

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 5/6] staging/android: refactor SYNC_IOC_FILE_INFO Gustavo Padovan <gustavo@padovan.org> - 2016-03-02 21:00 +0100
  Re: [PATCH v6 5/6] staging/android: refactor SYNC_IOC_FILE_INFO Maarten Lankhorst <maarten.lankhorst@linux.intel.com> - 2016-03-03 10:30 +0100
  [PATCH] staging/android: refactor SYNC_IOC_FILE_INFO Gustavo Padovan <gustavo@padovan.org> - 2016-03-03 15:40 +0100
    Re: [PATCH] staging/android: refactor SYNC_IOC_FILE_INFO Maarten Lankhorst <maarten.lankhorst@linux.intel.com> - 2016-03-03 16:10 +0100

csiph-web