Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1349258
| From | Josh Poimboeuf <jpoimboe@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] tools: Support relative directory path for 'O=' |
| Date | 2016-03-03 16:00 +0100 |
| Message-ID | <r8CTo-8sH-27@gated-at.bofh.it> (permalink) |
| References | <r8CA2-8lg-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Running "make O=foo" (with a relative directory path) fails with: scripts/Makefile.include:3: *** O=foo does not exist. Stop. /home/jpoimboe/git/linux/Makefile:1547: recipe for target 'tools/objtool' failed The tools Makefile gets confused by the relative path and tries to build objtool in tools/foo. Convert the output directory to an absolute path before passing it to the tools Makefile. Reported-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 3100e74..5b3723c 100644 --- a/Makefile +++ b/Makefile @@ -1541,11 +1541,11 @@ image_name: # Clear a bunch of variables before executing the submake tools/: FORCE $(Q)mkdir -p $(objtree)/tools - $(Q)$(MAKE) LDFLAGS= MAKEFLAGS="$(filter --j% -j,$(MAKEFLAGS))" O=$(O) subdir=tools -C $(src)/tools/ + $(Q)$(MAKE) LDFLAGS= MAKEFLAGS="$(filter --j% -j,$(MAKEFLAGS))" O=$(shell cd $(objtree) && /bin/pwd) subdir=tools -C $(src)/tools/ tools/%: FORCE $(Q)mkdir -p $(objtree)/tools - $(Q)$(MAKE) LDFLAGS= MAKEFLAGS="$(filter --j% -j,$(MAKEFLAGS))" O=$(O) subdir=tools -C $(src)/tools/ $* + $(Q)$(MAKE) LDFLAGS= MAKEFLAGS="$(filter --j% -j,$(MAKEFLAGS))" O=$(shell cd $(objtree) && /bin/pwd) subdir=tools -C $(src)/tools/ $* # Single targets # --------------------------------------------------------------------------- -- 2.4.3
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
linux-next: Tree for Mar 3 Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-03 07:10 +0100
Re: linux-next: Tree for Mar 3 Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-03 12:10 +0100
Re: linux-next: Tree for Mar 3 Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-03 12:20 +0100
Re: linux-next: Tree for Mar 3 Josh Poimboeuf <jpoimboe@redhat.com> - 2016-03-03 15:40 +0100
[PATCH] tools: Support relative directory path for 'O=' Josh Poimboeuf <jpoimboe@redhat.com> - 2016-03-03 16:00 +0100
[tip:core/objtool] tools: Support relative directory path for 'O=' tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2016-03-03 18:10 +0100
[PATCH] objtool: Warn if libelf is missing Josh Poimboeuf <jpoimboe@redhat.com> - 2016-03-03 18:50 +0100
Re: linux-next: Tree for Mar 3 Guenter Roeck <linux@roeck-us.net> - 2016-03-03 13:10 +0100
csiph-web