[PATCH] asix: do not free array priv->mdio->irq

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] asix: do not free array priv->mdio->irq
Date	Thu, 03 Mar 2016 14:30:03 +0100
Message-ID	<r8Buj-7F8-9@gated-at.bofh.it> (permalink)
X-Original-To	Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>, "David S . Miller" <davem@davemloft.net>, linux-usb@vger.kernel.org, netdev@vger.kernel.org
X-Mailer	git-send-email 2.7.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org
X-Original-Date	Thu, 3 Mar 2016 13:27:56 +0000
X-Original-Message-ID	<1457011676-19042-1-git-send-email-colin.king@canonical.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1349153

Show key headers only | View raw

From: Colin Ian King <colin.king@canonical.com>

Used to be allocated and required freeing, but now
priv->mdio->irq is now a fixed sized array and should no longer be
free'd.

Issue detected using static analysis with CoverityScan

Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/usb/ax88172a.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/usb/ax88172a.c b/drivers/net/usb/ax88172a.c
index 224e7d8..cf77f2d 100644
--- a/drivers/net/usb/ax88172a.c
+++ b/drivers/net/usb/ax88172a.c
@@ -134,7 +134,6 @@ static void ax88172a_remove_mdio(struct usbnet *dev)
 
 	netdev_info(dev->net, "deregistering mdio bus %s\n", priv->mdio->id);
 	mdiobus_unregister(priv->mdio);
-	kfree(priv->mdio->irq);
 	mdiobus_free(priv->mdio);
 }
 
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] asix: do not free array priv->mdio->irq Colin King <colin.king@canonical.com> - 2016-03-03 14:30 +0100
  Re: [PATCH] asix: do not free array priv->mdio->irq Andrew Lunn <andrew@lunn.ch> - 2016-03-03 15:30 +0100

csiph-web