Re: [PATCH 1/6] cpufreq: Reduce cpufreq_update_util() overhead a bit

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/6] cpufreq: Reduce cpufreq_update_util() overhead a bit
Date	2016-03-03 14:10 +0100
Message-ID	<r8BaX-7xs-29@gated-at.bofh.it> (permalink)
References	<r84I2-18B-15@gated-at.bofh.it> <r84I3-18B-49@gated-at.bofh.it> <r8zVx-6xi-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 03, 2016 at 11:47:01AM +0000, Juri Lelli wrote:

> > +#ifdef CONFIG_LOCKDEP
> > +	WARN_ON(debug_locks && !rcu_read_lock_sched_held());
> > +#endif
> >  
> >  	data = rcu_dereference(*this_cpu_ptr(&cpufreq_update_util_data));
> 
> I think you need to s/rcu_dereference/rcu_dereference_sched/ here or
> RCU will complain:

Ah, indeed ;-)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/6] cpufreq: Reduce cpufreq_update_util() overhead a bit "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-03-02 03:30 +0100
  Re: [PATCH 1/6] cpufreq: Reduce cpufreq_update_util() overhead a bit Viresh Kumar <viresh.kumar@linaro.org> - 2016-03-03 06:50 +0100
  Re: [PATCH 1/6] cpufreq: Reduce cpufreq_update_util() overhead a bit Juri Lelli <juri.lelli@arm.com> - 2016-03-03 12:50 +0100
    Re: [PATCH 1/6] cpufreq: Reduce cpufreq_update_util() overhead a bit Peter Zijlstra <peterz@infradead.org> - 2016-03-03 14:10 +0100

csiph-web