Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1349129
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 12/17] arm: Add new mach-oxnas |
| Date | 2016-03-03 14:00 +0100 |
| Message-ID | <r8B1h-7eH-19@gated-at.bofh.it> (permalink) |
| References | <r8zVw-6xi-13@gated-at.bofh.it> <r8zVw-6xi-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thursday 03 March 2016 12:40:05 Neil Armstrong wrote:
> +
> +config MACH_OX810SE
> + bool "Support OX810SE Based Products"
> + select CPU_ARM926T
> + select PLXTECH_RPS
> + select CLKSRC_RPS_TIMER
> + select RESET_OXNAS
> + select COMMON_CLK_OXNAS
> + select PINCTRL_OXNAS
Please sort these alphabetically
> +
> +static void __init oxnas_init(void)
> +{
> + pr_info("OXNAS Device Tree boot\n");
> +
> + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> +}
I think you should at least remove this function, as the pr_info is not
needed and the rest is the default.
As Russell mentioned, the entire file is not really needed either, but
so far we have left the trivial per-platform files in place generally.
Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 12/17] arm: Add new mach-oxnas Neil Armstrong <narmstrong@baylibre.com> - 2016-03-03 12:50 +0100
Re: [PATCH 12/17] arm: Add new mach-oxnas Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-03-03 12:50 +0100
Re: [PATCH 12/17] arm: Add new mach-oxnas Neil Armstrong <narmstrong@baylibre.com> - 2016-03-03 13:40 +0100
Re: [PATCH 12/17] arm: Add new mach-oxnas Arnd Bergmann <arnd@arndb.de> - 2016-03-03 14:00 +0100
Re: [PATCH 12/17] arm: Add new mach-oxnas Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-03-03 14:40 +0100
Re: [PATCH 12/17] arm: Add new mach-oxnas Arnd Bergmann <arnd@arndb.de> - 2016-03-03 14:50 +0100
csiph-web