Re: [RFC PATCH] kvm: Make KVM DF intercept configurable

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Jan Kiszka <jan.kiszka@siemens.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] kvm: Make KVM DF intercept configurable
Date	Wed, 02 Mar 2016 07:50:02 +0100
Message-ID	<r88LE-3PD-1@gated-at.bofh.it> (permalink)
References	<r7Y9A-53m-39@gated-at.bofh.it> <r7ZS1-6kT-1@gated-at.bofh.it> <r81h8-75L-5@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	Jörg Rödel <joro@8bytes.org>, Andy Lutomirski <luto@amacapital.net>, x86-ml <x86@kernel.org>, kvm ML <kvm@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>
X-Original-Date	Wed, 2 Mar 2016 07:45:53 +0100
X-Original-Message-ID	<56D68C21.7080602@siemens.com>
X-Original-References	<20160301192822.GD22677@pd.tnic> <56D6059D.5050606@redhat.com> <20160301224132.GE22677@pd.tnic>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1347810

Show key headers only | View raw

On 2016-03-01 23:41, Borislav Petkov wrote:
> On Tue, Mar 01, 2016 at 10:11:57PM +0100, Paolo Bonzini wrote:
>> I just use QEMU's binary translation mode to debug this kind of code (-d
>> in_asm is useful and relatively compact (because it only shows loops
>> once),
> 
> Ha, I had forgotten about "in_asm"! Thanks for reminding me, that's a
> really cool feature I'm going to use. With it I see:
> 
> ----------------
> IN: 
> 0x0000000001000000:  mov    0xffffffff81cba1f8,%rsp
> 0x0000000001000008:  callq  0x10001a9
> 
> ----------------
> 
> Now, it is obvious that 0xffffffff81cba1f8 is not mapped yet and we're
> running from physical addresses. The DF tracepoint shows, in addition,
> the previous exception vector causing the DF and I think that's useful.
> As an additional debugging aid. Oh, and that doesn't need ept=0 and runs
> at full speed.
> 
>> or alternatively ept=0. But perhaps... why not. :) It's not like it
>> adds overhead.
> 
> Yeah, it is off by default and doesn't hurt anyone. And the diff size
> is ok, IMHO. Lemme code the Intel side too and see how the whole thing
> turns out.

To make this a serious debug feature, we should consider trapping all
exceptions on request (and reinjecting the unhandled ones). Not sure
right now, though, if that comes with more complications than the simple
#DF case.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

Thread

[RFC PATCH] kvm: Make KVM DF intercept configurable Borislav Petkov <bp@alien8.de> - 2016-03-01 20:30 +0100
  Re: [RFC PATCH] kvm: Make KVM DF intercept configurable Paolo Bonzini <pbonzini@redhat.com> - 2016-03-01 22:20 +0100
    Re: [RFC PATCH] kvm: Make KVM DF intercept configurable Borislav Petkov <bp@alien8.de> - 2016-03-01 23:50 +0100
      Re: [RFC PATCH] kvm: Make KVM DF intercept configurable Jan Kiszka <jan.kiszka@siemens.com> - 2016-03-02 07:50 +0100
        Re: [RFC PATCH] kvm: Make KVM DF intercept configurable Borislav Petkov <bp@alien8.de> - 2016-03-02 10:10 +0100
          Re: [RFC PATCH] kvm: Make KVM DF intercept configurable Paolo Bonzini <pbonzini@redhat.com> - 2016-03-02 10:20 +0100
            Re: [RFC PATCH] kvm: Make KVM DF intercept configurable Borislav Petkov <bp@alien8.de> - 2016-03-02 10:30 +0100

csiph-web