[PATCH 3.14 075/130] sata_sil: disable trim

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	[PATCH 3.14 075/130] sata_sil: disable trim
Date	Wed, 02 Mar 2016 03:00:05 +0100
Message-ID	<r84f3-EO-57@gated-at.bofh.it> (permalink)
References	<r82dd-7Iy-13@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha1; c=relaxed/relaxed; s=mandrill; d=linuxfoundation.org; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Date:MIME-Version:Content-Type:Content-Transfer-Encoding; i=gregkh@linuxfoundation.org; bh=nc3/G1ltBP+m5P0mbmJWRmTQ/mA=; b=LJAdkzIwyRLa3+RW5Gr6sg5bKPyL8DoGMrshcrryP5h8QqeM4aNmMaUGziUQIvo+Ar+dmbJdZr7z YEG1zshx0v1odRD6alGvSY6IDNXRQlroJkJkBaiJ6HDGF+Ky6QFF/PTdYzxhwpEe8QPVnpsJnlBs 8Nqx1AFjvY2Zp9Eb1s8=
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1456876276; h=From : Subject : To : Cc : Message-Id : In-Reply-To : References : Date : MIME-Version : Content-Type : Content-Transfer-Encoding : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=cI3GelFmsLtYcBpMa6mlPO9rdzkUqtNFpPhk8x3h/9g=; b=qIVsU0Wyb4yort/JLD/nyKYY4pky3UkwUTYfPdXMfFpRqe8HnPOKwISYUvvbT6Q3cY1Sbx JYrXZUjUe2lwgNNVNJedBNC5OeUvMzvpnXuXZ7Ll7mQ4WMOrIhG3ieD0n5fakoNFlSSWAVAP IifR+zk2ViRL68eUKq8RsP1R5R2gQ=
X-Mailer	git-send-email 2.7.2
X-Report-Abuse	Please forward a copy of this message, including all headers, to abuse@mandrill.com
X-Report-Abuse	You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30481620.08ac3736d09a41fa8923995d7c6bc5cf
X-Mandrill-User	md_30481620
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
X-Original-Cc	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, <stable@vger.kernel.org>, Mikulas Patocka <mpatocka@redhat.com>, Tejun Heo <tj@kernel.org>
X-Original-Date	Tue, 01 Mar 2016 23:51:16 +0000
X-Original-Message-ID	<20160301234502.463665885@linuxfoundation.org>
X-Original-References	<20160301234459.768886030@linuxfoundation.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1347586

Show key headers only | View raw

3.14-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Mikulas Patocka <mpatocka@redhat.com>

commit d98f1cd0a3b70ea91f1dfda3ac36c3b2e1a4d5e2 upstream.

When I connect an Intel SSD to SATA SIL controller (PCI ID 1095:3114), any
TRIM command results in I/O errors being reported in the log. There is
other similar error reported with TRIM and the SIL controller:
https://bugs.centos.org/view.php?id=5880

Apparently the controller doesn't support TRIM commands. This patch
disables TRIM support on the SATA SIL controller.

ata7.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x0
ata7.00: BMDMA2 stat 0x50001
ata7.00: failed command: DATA SET MANAGEMENT
ata7.00: cmd 06/01:01:00:00:00/00:00:00:00:00/a0 tag 0 dma 512 out
         res 51/04:01:00:00:00/00:00:00:00:00/a0 Emask 0x1 (device error)
ata7.00: status: { DRDY ERR }
ata7.00: error: { ABRT }
ata7.00: device reported invalid CHS sector 0
sd 8:0:0:0: [sdb] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE
sd 8:0:0:0: [sdb] tag#0 Sense Key : Illegal Request [current] [descriptor]
sd 8:0:0:0: [sdb] tag#0 Add. Sense: Unaligned write command
sd 8:0:0:0: [sdb] tag#0 CDB: Write same(16) 93 08 00 00 00 00 00 21 95 88 00 20 00 00 00 00
blk_update_request: I/O error, dev sdb, sector 2200968

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/ata/sata_sil.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/drivers/ata/sata_sil.c
+++ b/drivers/ata/sata_sil.c
@@ -631,6 +631,9 @@ static void sil_dev_config(struct ata_de
 	unsigned int n, quirks = 0;
 	unsigned char model_num[ATA_ID_PROD_LEN + 1];
 
+	/* This controller doesn't support trim */
+	dev->horkage |= ATA_HORKAGE_NOTRIM;
+
 	ata_id_c_string(dev->id, model_num, ATA_ID_PROD, sizeof(model_num));
 
 	for (n = 0; sil_blacklist[n].product; n++)

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 3.14 075/130] sata_sil: disable trim Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-03-02 03:00 +0100

csiph-web