Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1347580
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/8] powerpc/module: Only try to generate the ftrace_caller() stub once |
| Date | 2016-03-02 03:00 +0100 |
| Message-ID | <r84f2-EO-43@gated-at.bofh.it> (permalink) |
| References | <r7sjo-198-3@gated-at.bofh.it> <r7sjp-198-23@gated-at.bofh.it> <r7RhM-wn-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 2016-03-01 at 13:00 +0100, Torsten Duwe wrote:
> On Mon, Feb 29, 2016 at 08:26:23PM +1100, Michael Ellerman wrote:
> [...]
> > diff --git a/arch/powerpc/kernel/module_32.c b/arch/powerpc/kernel/module_32.c
> > index 2c01665eb410..dd095496d225 100644
> > --- a/arch/powerpc/kernel/module_32.c
> > +++ b/arch/powerpc/kernel/module_32.c
> > @@ -294,11 +294,19 @@ int apply_relocate_add(Elf32_Shdr *sechdrs,
> > return -ENOEXEC;
> > }
> > }
> > +
> > + return 0;
> > +}
> > +
> > #ifdef CONFIG_DYNAMIC_FTRACE
> > - module->arch.tramp =
> > - do_plt_call(module->core_layout.base,
> > - (unsigned long)ftrace_caller,
> > - sechdrs, module);
> > -#endif
> > +int module_finalize_ftrace(struct module *module, const Elf_Shdr *sechdrs)
> > +{
> > + module->arch.tramp = do_plt_call(module->core_layout.base,
> > + (unsigned long)ftrace_caller,
> > + sechdrs, module);
> > + if (!mod->arch.tramp)
>
> That should probably read (!module->arch.tramp).
Hah, you expect me to compile my patches?! :)
cheers
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/8] powerpc: Create a helper for getting the kernel toc value Michael Ellerman <mpe@ellerman.id.au> - 2016-02-29 10:30 +0100
[PATCH v2 7/8] powerpc/ftrace: Add support for -mprofile-kernel ftrace ABI Michael Ellerman <mpe@ellerman.id.au> - 2016-02-29 10:30 +0100
[PATCH v2 8/8] powerpc/ftrace: Add Kconfig & Make glue for mprofile-kernel Michael Ellerman <mpe@ellerman.id.au> - 2016-02-29 10:30 +0100
[PATCH v2 2/8] powerpc/module: Only try to generate the ftrace_caller() stub once Michael Ellerman <mpe@ellerman.id.au> - 2016-02-29 10:30 +0100
Re: [PATCH v2 2/8] powerpc/module: Only try to generate the ftrace_caller() stub once Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> - 2016-03-01 11:10 +0100
Re: [PATCH v2 2/8] powerpc/module: Only try to generate the ftrace_caller() stub once Torsten Duwe <duwe@lst.de> - 2016-03-01 13:10 +0100
Re: [PATCH v2 2/8] powerpc/module: Only try to generate the ftrace_caller() stub once Michael Ellerman <mpe@ellerman.id.au> - 2016-03-02 03:00 +0100
[PATCH v2 3/8] powerpc/module: Mark module stubs with a magic value Michael Ellerman <mpe@ellerman.id.au> - 2016-02-29 10:30 +0100
Re: [PATCH v2 1/8] powerpc: Create a helper for getting the kernel toc value Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> - 2016-03-01 11:00 +0100
Re: [PATCH v2 1/8] powerpc: Create a helper for getting the kernel toc value Torsten Duwe <duwe@lst.de> - 2016-03-01 13:00 +0100
csiph-web