Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1347376

Re: [PATCH v3 9/9] x86/xsaves: Re-enable XSAVES

From Yu-cheng Yu <yu-cheng.yu@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3 9/9] x86/xsaves: Re-enable XSAVES
Date 2016-03-02 02:00 +0100
Message-ID <r83iY-8oR-61@gated-at.bofh.it> (permalink)
References <r7A7g-67h-3@gated-at.bofh.it> <r7A7h-67h-43@gated-at.bofh.it> <r82ZB-8hp-37@gated-at.bofh.it> <r82ZB-8hp-35@gated-at.bofh.it> <r839f-8lk-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 01, 2016 at 04:45:41PM -0800, Dave Hansen wrote:
> >>> +	WARN_ONCE((xfeatures_mask & XFEATURE_MASK_SUPERVISOR),
> >>> +		"x86/fpu: XSAVES supervisor states are not yet implemented.\n");
> >>> +
> >>>  	cr4_set_bits(X86_CR4_OSXSAVE);
> >>>  	xsetbv(XCR_XFEATURE_ENABLED_MASK, xfeatures_mask);
> >>>  }
> >>
> >> Let's also do a:
> >>
> >> 	xfeatures_mask &= ~XFEATURE_MASK_SUPERVISOR;
> >>
> >> Otherwise, we have a broken system at the moment.
> >>
> > Currently, if anyone sets any supervisor state in xfeatures_mask, the
> > kernel prints out the warning then goes into a protection fault.
> > That is a very strong indication to the user. Do we want to mute it? 
> 
> By "goes into a protection fault", do you mean that it doesn't boot?
> 
> I'd just rather we put the kernel in a known-safe configuration (masking
> supervisor state out of xfeatures_mask) rather than rely on the general
> protection fault continuing to be generated by whatever is generating it.
> 
Ok.

Yu-cheng

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 9/9] x86/xsaves: Re-enable XSAVES Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-02-29 18:50 +0100
  Re: [PATCH v3 9/9] x86/xsaves: Re-enable XSAVES Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-03-02 01:40 +0100
    Re: [PATCH v3 9/9] x86/xsaves: Re-enable XSAVES Dave Hansen <dave.hansen@linux.intel.com> - 2016-03-02 01:50 +0100
      Re: [PATCH v3 9/9] x86/xsaves: Re-enable XSAVES Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-03-02 02:00 +0100
      Re: [PATCH v3 9/9] x86/xsaves: Re-enable XSAVES "H. Peter Anvin" <hpa@zytor.com> - 2016-03-02 02:00 +0100
        Re: [PATCH v3 9/9] x86/xsaves: Re-enable XSAVES Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-03-02 02:10 +0100
  Re: [PATCH v3 9/9] x86/xsaves: Re-enable XSAVES Dave Hansen <dave.hansen@linux.intel.com> - 2016-03-02 02:00 +0100

csiph-web