Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node

From	Andreas Färber <afaerber@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node
Date	2016-03-02 00:40 +0100
Message-ID	<r823v-7Ff-15@gated-at.bofh.it> (permalink)
References	<r7FJD-1gw-7@gated-at.bofh.it> <r7FJE-1gw-25@gated-at.bofh.it> <r7QlI-8lK-1@gated-at.bofh.it> <r7Qvo-8px-11@gated-at.bofh.it> <r7RUt-LY-7@gated-at.bofh.it>
Organization	SUSE Linux GmbH

Show all headers | View raw

Hi,

Am 01.03.2016 um 13:43 schrieb Andre Przywara:
> On 01/03/16 11:18, Andreas Färber wrote:
>> Am 01.03.2016 um 12:01 schrieb Andre Przywara:
>>> On 29/02/16 23:44, Andreas Färber wrote:
>>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>>>> index 0ae089bd1806..5088ae3ff653 100644
>>>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>>>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>>>> @@ -117,7 +117,9 @@
>>>>  		gic: interrupt-controller@c4301000 {
>>>>  			compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";
>>>
>>> I think "arm,gic-400" is the name to use here these days, especially for
>>> arm64.
>>
>> I took what /proc/device-tree showed on Android and verified that this
>> compatible is in use in mainline.
> 
> Some vendor Android kernel is not a good reference for mainline work ;-)
> Better look at other DTs in arch/arm64/boot/dts.

Yes, that's what "in use in mainline" refers to:

$ git grep "cortex-a15-gic" -- arch/arm64/boot/dts/ | grep -v gic-400
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi: compatible =
"arm,cortex-a15-gic";
arch/arm64/boot/dts/apm/apm-storm.dtsi: compatible = "arm,cortex-a15-gic";
arch/arm64/boot/dts/arm/foundation-v8.dts: compatible =
"arm,cortex-a15-gic", "arm,cortex-a9-gic";
arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts: compatible =
"arm,cortex-a15-gic", "arm,cortex-a9-gic";
arch/arm64/boot/dts/nvidia/tegra132.dtsi: compatible = "arm,cortex-a15-gic";

> You could keep "arm,cortex-a15-gic" in there if you care about
> compatibility with older (vendor) kernels, but I guess there are other
> issues which prevent this anyway, so you could drop this as well.

Yeah, I don't care about backwards compatibility with downstream
kernels, they use weird compatible strings with spaces anyway.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

Thread

[PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node Andreas Färber <afaerber@suse.de> - 2016-03-01 00:50 +0100
  Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node Andre Przywara <andre.przywara@arm.com> - 2016-03-01 12:10 +0100
    Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node Andreas Färber <afaerber@suse.de> - 2016-03-01 12:20 +0100
      Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node Matthias Brugger <mbrugger@suse.com> - 2016-03-01 12:50 +0100
      Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node Andre Przywara <andre.przywara@arm.com> - 2016-03-01 13:50 +0100
        Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node Carlo Caione <carlo@caione.org> - 2016-03-01 14:00 +0100
          Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node Andre Przywara <andre.przywara@arm.com> - 2016-03-01 15:20 +0100
        Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node Andreas Färber <afaerber@suse.de> - 2016-03-01 23:50 +0100
          Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node André Przywara <andre.przywara@arm.com> - 2016-03-02 00:00 +0100
        Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node Andreas Färber <afaerber@suse.de> - 2016-03-02 00:40 +0100
          Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node Andreas Färber <afaerber@suse.de> - 2016-03-02 01:10 +0100
          Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node André Przywara <andre.przywara@arm.com> - 2016-03-02 01:10 +0100

csiph-web