Re: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction
Date	2016-02-29 18:30 +0100
Message-ID	<r7zNT-60o-7@gated-at.bofh.it> (permalink)
References	(2 earlier) <r7eJs-6Q8-13@gated-at.bofh.it> <r7eT8-79F-15@gated-at.bofh.it> <r7mdY-3Qp-3@gated-at.bofh.it> <r7xsJ-4mV-5@gated-at.bofh.it> <r7z1x-5sW-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 29, 2016 at 01:31:44PM -0300, Henrique de Moraes Holschuh wrote:
> Fully agreed.  That said, it would be nice to have a patchset (intended
> mostly for stable/LTS backporting) that restricts MSR access to a *static*
> whitelist that allows only the minimal access required by the current crop
> of general use utilities like powertop, turbostat, etc.

As I said before, if people want to shoot themselves in the foot, we
can't stop them.

However, we should start converting those tools away from msr.ko and
towards proper OS interfaces instead. And not a short list it is (this
only in the kernel repo) ... :-\

$ git grep -lE "cpu/.*/msr" | uniq
Documentation/devices.txt
arch/x86/Kconfig
arch/x86/kernel/msr.c
tools/power/cpupower/debug/i386/centrino-decode.c
tools/power/cpupower/debug/i386/powernow-k8-decode.c
tools/power/cpupower/man/cpupower-monitor.1
tools/power/cpupower/utils/cpupower.c
tools/power/cpupower/utils/helpers/msr.c
tools/power/x86/turbostat/turbostat.8
tools/power/x86/turbostat/turbostat.c
tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.8
tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
tools/testing/selftests/intel_pstate/aperf.c
tools/testing/selftests/intel_pstate/msr.c

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Thread

[PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction Marty McFadden <mcfadden8@llnl.gov> - 2016-02-26 01:20 +0100
  Re: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction Ingo Molnar <mingo@kernel.org> - 2016-02-26 08:40 +0100
    RE: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction "Mcfadden, Marty Jay" <mcfadden8@llnl.gov> - 2016-02-28 20:00 +0100
      Re: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction Borislav Petkov <bp@alien8.de> - 2016-02-28 20:10 +0100
        RE: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction "Mcfadden, Marty Jay" <mcfadden8@llnl.gov> - 2016-02-29 04:00 +0100
          Re: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction Borislav Petkov <bp@alien8.de> - 2016-02-29 16:00 +0100
            Re: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-02-29 17:40 +0100
              Re: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction Borislav Petkov <bp@alien8.de> - 2016-02-29 18:30 +0100
            Re: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction "George Spelvin" <linux@horizon.com> - 2016-02-29 19:00 +0100
              Re: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction Borislav Petkov <bp@alien8.de> - 2016-02-29 19:30 +0100
                RE: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction "Mcfadden, Marty Jay" <mcfadden8@llnl.gov> - 2016-02-29 23:40 +0100
                Re: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction Borislav Petkov <bp@alien8.de> - 2016-03-01 00:50 +0100
                Re: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction "Rountree, Barry L." <rountree4@llnl.gov> - 2016-03-01 20:10 +0100
                Re: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction Andy Lutomirski <luto@amacapital.net> - 2016-03-03 01:50 +0100
                RE: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction Thomas Gleixner <tglx@linutronix.de> - 2016-03-01 09:10 +0100
                Re: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction Borislav Petkov <bp@alien8.de> - 2016-03-01 19:40 +0100
                Re: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction "Rountree, Barry L." <rountree4@llnl.gov> - 2016-03-01 19:40 +0100
          RE: [PATCH 0/4] MSR: MSR: MSR Whitelist and Batch Introduction Andy Lutomirski <luto@amacapital.net> - 2016-02-29 18:20 +0100

csiph-web