Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1345938

Re: [patch 10/20] cpu/hotplug: Make target state writeable

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [patch 10/20] cpu/hotplug: Make target state writeable
Date Mon, 29 Feb 2016 17:00:03 +0100
Message-ID <r7yoP-4YQ-33@gated-at.bofh.it> (permalink)
References <r6vCG-7sv-3@gated-at.bofh.it> <r6Aj0-2oo-11@gated-at.bofh.it> <r6HNv-88y-7@gated-at.bofh.it> <r6OlY-4r1-3@gated-at.bofh.it> <r7aZc-3Z9-9@gated-at.bofh.it>
X-Original-To "Rafael J. Wysocki" <rjw@rjwysocki.net>
User-Agent Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version 1.0
Content-Type TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score -1.0
X-Linutronix-Spam-Level -
X-Linutronix-Spam-Status No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 36
Organization linux.* mail to news gateway
X-Original-Cc LKML <linux-kernel@vger.kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>, Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Peter Anvin <hpa@zytor.com>, Oleg Nesterov <oleg@redhat.com>, linux-arch@vger.kernel.org, Tejun Heo <tj@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Rusty Russell <rusty@rustcorp.com.au>, Paul McKenney <paulmck@linux.vnet.ibm.com>, Rafael Wysocki <rafael.j.wysocki@intel.com>, Arjan van de Ven <arjan@linux.intel.com>, Rik van Riel <riel@redhat.com>, "Srivatsa S. Bhat" <srivatsa@mit.edu>, Sebastian Siewior <bigeasy@linutronix.de>, Paul Turner <pjt@google.com>
X-Original-Date Mon, 29 Feb 2016 16:49:24 +0100 (CET)
X-Original-Message-ID <alpine.DEB.2.11.1602291648210.3638@nanos>
X-Original-References <20160226164321.657646833@linutronix.de> <6355023.m2RKuauZef@vostro.rjw.lan> <alpine.DEB.2.11.1602270823480.3638@nanos> <1490843.2y32Taz9fS@vostro.rjw.lan> <alpine.DEB.2.11.1602281545140.3638@nanos>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1345938

Show key headers only | View raw


On Sun, 28 Feb 2016, Thomas Gleixner wrote:
> 
> Understood. I'll fix that thing up so that won't happen and I put it on the
> list of things to look at deeper.

The below delta patch should do what you need, right?

Thanks,

	tglx

8<-------------

--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -1461,6 +1461,11 @@ static ssize_t write_cpuhp_target(struct
 	if (target != CPUHP_OFFLINE && target != CPUHP_ONLINE)
 		return -EINVAL;
 #endif
+
+	ret = lock_device_hotplug_sysfs();
+	if (ret)
+		return ret;
+
 	mutex_lock(&cpuhp_state_mutex);
 	sp = cpuhp_get_step(target);
 	ret = !sp->name || sp->cant_stop ? -EINVAL : 0;
@@ -1472,6 +1477,8 @@ static ssize_t write_cpuhp_target(struct
 		ret = do_cpu_up(dev->id, target);
 	else
 		ret = do_cpu_down(dev->id, target);
+
+	unlock_device_hotplug();
 	return ret ? ret : count;
 }
 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[patch 10/20] cpu/hotplug: Make target state writeable Thomas Gleixner <tglx@linutronix.de> - 2016-02-26 19:50 +0100
  Re: [patch 10/20] cpu/hotplug: Make target state writeable "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-27 00:50 +0100
    Re: [patch 10/20] cpu/hotplug: Make target state writeable Thomas Gleixner <tglx@linutronix.de> - 2016-02-27 08:50 +0100
      Re: [patch 10/20] cpu/hotplug: Make target state writeable "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-27 15:50 +0100
        Re: [patch 10/20] cpu/hotplug: Make target state writeable Thomas Gleixner <tglx@linutronix.de> - 2016-02-28 16:00 +0100
          Re: [patch 10/20] cpu/hotplug: Make target state writeable Thomas Gleixner <tglx@linutronix.de> - 2016-02-29 17:00 +0100
            Re: [patch 10/20] cpu/hotplug: Make target state writeable "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-03-01 03:00 +0100
  [tip:smp/hotplug] cpu/hotplug: Make target state writeable tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2016-03-01 21:00 +0100
    Re: [tip:smp/hotplug] cpu/hotplug: Make target state writeable Peter Zijlstra <peterz@infradead.org> - 2016-03-02 13:50 +0100
      Re: [tip:smp/hotplug] cpu/hotplug: Make target state writeable Thomas Gleixner <tglx@linutronix.de> - 2016-03-02 21:00 +0100

csiph-web