Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1345662

[tip:perf/core] perf/x86/intel/uncore: Remove SBOX support for BDX-DE

Show all headers | View raw

Commit-ID:  6cb2f1d9af5b0f0afdd4e689d969df4b5c76a4c2
Gitweb:     http://git.kernel.org/tip/6cb2f1d9af5b0f0afdd4e689d969df4b5c76a4c2
Author:     Kan Liang <kan.liang@intel.com>
AuthorDate: Wed, 24 Feb 2016 05:07:43 -0500
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 29 Feb 2016 09:35:11 +0100

perf/x86/intel/uncore: Remove SBOX support for BDX-DE

BDX-DE and BDX-EP share the same uncore code path. But there is no sbox
in BDX-DE. This patch remove SBOX support for BDX-DE.

Signed-off-by: Kan Liang <kan.liang@intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: <stable@vger.kernel.org>
Cc: <tonyb@cybernetics.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Battersby <tonyb@cybernetics.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: http://lkml.kernel.org/r/37D7C6CF3E00A74B8858931C1DB2F0770589D336@SHSMSX103.ccr.corp.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/events/intel/uncore_snbep.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
index 0c801f7..d967fcc 100644
--- a/arch/x86/events/intel/uncore_snbep.c
+++ b/arch/x86/events/intel/uncore_snbep.c
@@ -2874,11 +2874,13 @@ static struct intel_uncore_type bdx_uncore_sbox = {
 	.format_group		= &hswep_uncore_sbox_format_group,
 };
 
+#define BDX_MSR_UNCORE_SBOX	3
+
 static struct intel_uncore_type *bdx_msr_uncores[] = {
 	&bdx_uncore_ubox,
 	&bdx_uncore_cbox,
-	&bdx_uncore_sbox,
 	&hswep_uncore_pcu,
+	&bdx_uncore_sbox,
 	NULL,
 };
 
@@ -2887,6 +2889,10 @@ void bdx_uncore_cpu_init(void)
 	if (bdx_uncore_cbox.num_boxes > boot_cpu_data.x86_max_cores)
 		bdx_uncore_cbox.num_boxes = boot_cpu_data.x86_max_cores;
 	uncore_msr_uncores = bdx_msr_uncores;
+
+	/* BDX-DE doesn't have SBOX */
+	if (boot_cpu_data.x86_model == 86)
+		uncore_msr_uncores[BDX_MSR_UNCORE_SBOX] = NULL;
 }
 
 static struct intel_uncore_type bdx_uncore_ha = {

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: PROBLEM: lk 4.5 oops on boot with Xeon D-1520 Thomas Gleixner <tglx@linutronix.de> - 2016-02-24 10:20 +0100
  RE: PROBLEM: lk 4.5 oops on boot with Xeon D-1520 "Liang, Kan" <kan.liang@intel.com> - 2016-02-24 16:40 +0100
    RE: PROBLEM: lk 4.5 oops on boot with Xeon D-1520 "Liang, Kan" <kan.liang@intel.com> - 2016-02-24 17:40 +0100
      Re: PROBLEM: lk 4.5 oops on boot with Xeon D-1520 Peter Zijlstra <peterz@infradead.org> - 2016-02-24 18:50 +0100
    Re: PROBLEM: lk 4.5 oops on boot with Xeon D-1520 Tony Battersby <tonyb@cybernetics.com> - 2016-02-24 17:40 +0100
    [tip:perf/core] perf/x86/intel/uncore: Remove SBOX support for  BDX-DE tip-bot for Kan Liang <tipbot@zytor.com> - 2016-02-29 12:10 +0100

csiph-web