Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1345610

Re: [PATCH] iommu: exynos: pointers are nto physical addresses

Show all headers | View raw

On Monday 29 February 2016 10:33:59 Marek Szyprowski wrote:
> > ---
> > I also see that some incorrect __raw_writel() calls have crept in
> > around the same time, which breaks running big-endian kernels when
> > this driver is loaded.
> >
> > Please fix and that that as well.
> 
> Okay, so in the driver code all __raw_writel should be replaced by
> writel(), right?

Yes, writel() is always the safe choice if you don't know what to
use. __raw_writel() should be considered an implementation detail
and not used in drivers at all. There is also writel_relaxed(),
which is faster than writel() because it leaves out all the
barriers (as __raw_writel does too), and you can sometimes use that
in the fast path if you can prove that no barriers are needed.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] iommu: exynos: pointers are nto physical addresses Arnd Bergmann <arnd@arndb.de> - 2016-02-29 09:50 +0100
  Re: [PATCH] iommu: exynos: pointers are nto physical addresses Marek Szyprowski <m.szyprowski@samsung.com> - 2016-02-29 10:40 +0100
    Re: [PATCH] iommu: exynos: pointers are nto physical addresses Arnd Bergmann <arnd@arndb.de> - 2016-02-29 11:00 +0100
  Re: [PATCH] iommu: exynos: pointers are nto physical addresses Joerg Roedel <joro@8bytes.org> - 2016-02-29 16:50 +0100

csiph-web