Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1345585

Re: + kernel-locking-lockdepc-make-lockdep-initialize-itself-on-demand.patch added to -mm tree

From Ingo Molnar <mingo@kernel.org>
Newsgroups linux.kernel
Subject Re: + kernel-locking-lockdepc-make-lockdep-initialize-itself-on-demand.patch added to -mm tree
Date 2016-02-29 10:20 +0100
Message-ID <r7s9I-15P-7@gated-at.bofh.it> (permalink)
References <qY0mm-7ok-27@gated-at.bofh.it> <qY0mm-7ok-25@gated-at.bofh.it> <qY8MW-4sb-9@gated-at.bofh.it> <r0euR-3fE-15@gated-at.bofh.it> <r0mVs-wW-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 9 Feb 2016 12:12:29 +0100 Ingo Molnar <mingo@kernel.org> wrote:
> 
> > > The conceptual problem is that if some piece of code does spin_lock_init() or 
> > > DEFINE_SPINLOCK(), that lock isn't necessarily initialized yet.
> > 
> > The conceptual problem is that the data structures are not build time initialized 
> > - but the hlist conversion patch solves that problem nicely!
> > 
> > So I'm a happy camper.
> 
> OK, so the below has been in -next for nearly a week, no issues.  We
> should get this into 4.5 to fix the CONFIG_UBSAN_ALIGNMENT issue.

So I think this patch broke liblockdep:

triton:~/tip/tools/lib/lockdep> 

In file included from lockdep.c:2:0:
../../../kernel/locking/lockdep.c: In function ‘look_up_lock_class’:
../../../kernel/locking/lockdep.c:722:2: warning: implicit declaration of function ‘hlist_for_each_entry_rcu’ [-Wimplicit-function-declaration]
  hlist_for_each_entry_rcu(class, hash_head, hash_entry) {

...

Thanks,

	Ingo

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: +  kernel-locking-lockdepc-make-lockdep-initialize-itself-on-demand.patch added  to -mm tree Ingo Molnar <mingo@kernel.org> - 2016-02-29 10:20 +0100
  Re: +  kernel-locking-lockdepc-make-lockdep-initialize-itself-on-demand.patch added  to -mm tree Ingo Molnar <mingo@kernel.org> - 2016-02-29 10:30 +0100
    Re: +  kernel-locking-lockdepc-make-lockdep-initialize-itself-on-demand.patch added  to -mm tree Andrey Ryabinin <aryabinin@virtuozzo.com> - 2016-02-29 10:40 +0100

csiph-web