Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1345568

Re: [PATCH v4 3/5] staging/android: remove redundant comments on sync_merge_data

Show all headers | View raw

Op 26-02-16 om 19:31 schreef Gustavo Padovan:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> struct sync_merge_data already have documentation on top of the
> struct definition. No need to duplicate it.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> ---
>  drivers/staging/android/uapi/sync.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/android/uapi/sync.h b/drivers/staging/android/uapi/sync.h
> index dd0dd84..f0b41ce 100644
> --- a/drivers/staging/android/uapi/sync.h
> +++ b/drivers/staging/android/uapi/sync.h
> @@ -21,9 +21,9 @@
>   * @fence:	returns the fd of the new fence to userspace
>   */
>  struct sync_merge_data {
> -	__s32	fd2; /* fd of second fence */
> -	char	name[32]; /* name of new fence */
> -	__s32	fence; /* fd on newly created fence */
> +	__s32	fd2;
> +	char	name[32];
> +	__s32	fence;
>  };
>  
>  /**
For the first 3 patches:

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 3/5] staging/android: remove redundant comments on sync_merge_data Gustavo Padovan <gustavo@padovan.org> - 2016-02-26 19:40 +0100
  Re: [PATCH v4 3/5] staging/android: remove redundant comments on  sync_merge_data Maarten Lankhorst <maarten.lankhorst@linux.intel.com> - 2016-02-29 09:40 +0100

csiph-web