Re: [PATCH 1/7] extcon: palmas: Drop IRQF_EARLY_RESUME flag

From	Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/7] extcon: palmas: Drop IRQF_EARLY_RESUME flag
Date	2016-02-29 03:30 +0100
Message-ID	<r7lKW-3F2-1@gated-at.bofh.it> (permalink)
References	<r6sOt-5pp-1@gated-at.bofh.it> <r6sOu-5pp-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Grygorii,

On 2016년 02월 27일 00:42, Grygorii Strashko wrote:
> Palams extcon IRQs are nested threaded and wired to the Palmas
> inerrupt controller. So, this flag is not required for nested irqs
> anymore, since commit 3c646f2c6aa9 ("genirq: Don't suspend
> nested_thread irqs over system suspend") was merged.
> 
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Roger Quadros <rogerq@ti.com>
> Cc: Nishanth Menon <nm@ti.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
>  drivers/extcon/extcon-palmas.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index 93c30a8..0a861b3 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -266,7 +266,7 @@ static int palmas_usb_probe(struct platform_device *pdev)
>  				palmas_usb->id_irq,
>  				NULL, palmas_id_irq_handler,
>  				IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING |
> -				IRQF_ONESHOT | IRQF_EARLY_RESUME,
> +				IRQF_ONESHOT,
>  				"palmas_usb_id", palmas_usb);
>  		if (status < 0) {
>  			dev_err(&pdev->dev, "can't get IRQ %d, err %d\n",
> @@ -304,7 +304,7 @@ static int palmas_usb_probe(struct platform_device *pdev)
>  				palmas_usb->vbus_irq, NULL,
>  				palmas_vbus_irq_handler,
>  				IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING |
> -				IRQF_ONESHOT | IRQF_EARLY_RESUME,
> +				IRQF_ONESHOT,
>  				"palmas_usb_vbus", palmas_usb);
>  		if (status < 0) {
>  			dev_err(&pdev->dev, "can't get IRQ %d, err %d\n",
> 

Applied it on extcon git.

Thanks,
Chanwoo Choi

Thread

[PATCH 0/7] mfd: Drop IRQF_EARLY_RESUME flag Grygorii Strashko <grygorii.strashko@ti.com> - 2016-02-26 16:50 +0100
  [PATCH 4/7] rtc: tps65910: Drop IRQF_EARLY_RESUME flag Grygorii Strashko <grygorii.strashko@ti.com> - 2016-02-26 16:50 +0100
  [PATCH 5/7] rtc: tps80031: Drop IRQF_EARLY_RESUME flag Grygorii Strashko <grygorii.strashko@ti.com> - 2016-02-26 16:50 +0100
  [PATCH 1/7] extcon: palmas: Drop IRQF_EARLY_RESUME flag Grygorii Strashko <grygorii.strashko@ti.com> - 2016-02-26 16:50 +0100
    Re: [PATCH 1/7] extcon: palmas: Drop IRQF_EARLY_RESUME flag Chanwoo Choi <cw00.choi@samsung.com> - 2016-02-29 03:30 +0100
  [PATCH 7/7] iio: adc: palmas: Drop IRQF_EARLY_RESUME flag Grygorii Strashko <grygorii.strashko@ti.com> - 2016-02-26 16:50 +0100
    Re: [PATCH 7/7] iio: adc: palmas: Drop IRQF_EARLY_RESUME flag Jonathan Cameron <jic23@kernel.org> - 2016-02-27 18:30 +0100
  [PATCH 6/7] rtc: as3722: Drop IRQF_EARLY_RESUME flag Grygorii Strashko <grygorii.strashko@ti.com> - 2016-02-26 16:50 +0100
  [PATCH 2/7] rtc: palmas: Drop IRQF_EARLY_RESUME flag Grygorii Strashko <grygorii.strashko@ti.com> - 2016-02-26 16:50 +0100
  [PATCH 3/7] rtc: tps6586x: Drop IRQF_EARLY_RESUME flag Grygorii Strashko <grygorii.strashko@ti.com> - 2016-02-26 16:50 +0100
  Re: [PATCH 0/7] mfd: Drop IRQF_EARLY_RESUME flag Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-02-29 00:50 +0100

csiph-web