Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1345404

[PATCH] [RFC] mm/page_ref, crypto/async_pq: don't put_page from __exit

Show all headers | View raw

The addition of tracepoints to the page reference tracking had an
unfortunate side-effect in at least one driver that calls put_page
from its exit function, resulting in a link error:

`.exit.text' referenced in section `__jump_table' of crypto/built-in.o: defined in discarded section `.exit.text' of crypto/built-in.o

I could not come up with a nice solution that ignores __jump_table
entries in discarded code, so we probably now have to treat this
as something a driver is not allowed to do. Removing the __exit
annotation avoids the problem in this particular driver, but the
same problem could come back any time in other code.

On a related problem regarding the runtime patching for SMP
operations on ARM uniprocessor systems, we resorted to not
drop the .exit section at link time, but that doesn't seem
appropriate here.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 0f80830dd044 ("mm/page_ref: add tracepoint to track down page reference manipulation")
---
 crypto/async_tx/async_pq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/async_tx/async_pq.c b/crypto/async_tx/async_pq.c
index c0748bbd4c08..be167145aa55 100644
--- a/crypto/async_tx/async_pq.c
+++ b/crypto/async_tx/async_pq.c
@@ -442,7 +442,7 @@ static int __init async_pq_init(void)
 	return -ENOMEM;
 }
 
-static void __exit async_pq_exit(void)
+static void async_pq_exit(void)
 {
 	put_page(pq_scribble_page);
 }
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] [RFC] mm/page_ref, crypto/async_pq: don't put_page from __exit Arnd Bergmann <arnd@arndb.de> - 2016-02-28 23:00 +0100
  Re: [PATCH] [RFC] mm/page_ref, crypto/async_pq: don't put_page from __exit Joonsoo Kim <js1304@gmail.com> - 2016-02-29 08:50 +0100
    Re: [PATCH] [RFC] mm/page_ref, crypto/async_pq: don't put_page from __exit Arnd Bergmann <arnd@arndb.de> - 2016-02-29 10:40 +0100

csiph-web