Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1345362

Re: [PATCH v2 04/13] ARM: dts: sun8i-a83t: Add basic clocks and resets

From Chen-Yu Tsai <wens@csie.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 04/13] ARM: dts: sun8i-a83t: Add basic clocks and resets
Date 2016-02-28 18:30 +0100
Message-ID <r7dkl-5TV-1@gated-at.bofh.it> (permalink)
References <r7bix-4oZ-3@gated-at.bofh.it> <r7bix-4oZ-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, Feb 28, 2016 at 7:18 AM, Vishnu Patekar
<vishnupatekar0510@gmail.com> wrote:
> This adds A83T system bus clocks, bus gates, and clock resets.
>
> Three ahb reset registers are combined into one node.
>
> Signed-off-by: Vishnu Patekar <vishnupatekar0510@gmail.com>
> ---
>  arch/arm/boot/dts/sun8i-a83t.dtsi | 114 +++++++++++++++++++++++++++++++++++++-
>  1 file changed, 112 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> index d3473f8..fa7ded5 100644
> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> @@ -146,6 +146,97 @@
>                         clocks = <&osc16M>;
>                         clock-output-names = "osc16M-d512";
>                 };
> +
> +               pll6: clk@01c20028 {
> +                       #clock-cells = <0>;
> +                       compatible = "allwinner,sun9i-a80-pll4-clk";
> +                       reg = <0x01c20028 0x4>;
> +                       clocks = <&osc24M>;
> +                       clock-output-names = "pll6";
> +               };
> +
> +               pll6d2: pll6d2_clk {
> +                       #clock-cells = <0>;
> +                       compatible = "fixed-factor-clock";
> +                       clock-div = <2>;
> +                       clock-mult = <1>;
> +                       clocks = <&pll6>;
> +                       clock-output-names = "pll6d2";
> +               };
> +
> +               ahb1: clk@01c20054 {
> +                       #clock-cells = <0>;
> +                       compatible = "allwinner,sun8i-a83t-ahb1-clk";
> +                       reg = <0x01c20054 0x4>;
> +                       clocks = <&osc16Md512>, <&osc24M>, <&pll6>, <&pll6>;
> +                       clock-output-names = "ahb1";
> +               };
> +
> +               apb1: apb1_clk@01c20054 {
> +                       #clock-cells = <0>;
> +                       compatible = "allwinner,sun8i-a83t-apb1-clk";
> +                       reg = <0x01c20054 0x4>;
> +                       clocks = <&ahb1>;
> +                       clock-output-names = "apb1";
> +               };
> +
> +               apb2: clk@01c20058 {
> +                       #clock-cells = <0>;
> +                       compatible = "allwinner,sun4i-a10-apb1-clk";
> +                       reg = <0x01c20058 0x4>;
> +                       clocks = <&osc16Md512>, <&osc24M>, <&pll6>, <&pll6>;
> +                       clock-output-names = "apb2";
> +               };
> +
> +               ahb2: clk@01c2005c {
> +                       #clock-cells = <0>;
> +                       compatible = "allwinner,sun8i-h3-ahb2-clk";
> +                       reg = <0x01c2005c 0x4>;
> +                       clocks = <&ahb1>, <&pll6d2>;
> +                       clock-output-names = "ahb2";
> +               };
> +
> +               bus_gates: clk@01c20060 {
> +                       #clock-cells = <1>;
> +                       compatible = "allwinner,sun8i-a83t-bus-gates-clk";
> +                       reg = <0x01c20060 0x10>;
> +                       clocks = <&ahb1>, <&ahb2>, <&apb1>, <&apb2>;
> +                       clock-names = "ahb1", "ahb2", "apb1", "apb2";
> +                       clock-indices = <1>, <5>, <6>,
> +                                       <8>, <9>, <10>,
> +                                       <13>, <14>, <17>,
> +                                       <19>, <20>,
> +                                       <21>, <24>,
> +                                       <26>, <27>,
> +                                       <29>, <32>,
> +                                       <36>, <37>,
> +                                       <40>, <43>,
> +                                       <44>, <52>, <53>,
> +                                       <54>, <65>,
> +                                       <69>, <76>, <77>,
> +                                       <78>, <79>, <96>,
> +                                       <97>, <98>,
> +                                       <112>, <113>,
> +                                       <114>, <115>,
> +                                       <116>;
> +                       clock-output-names = "bus_mipidsi", "bus_ss", "bus_dma",
> +                                            "bus_mmc0", "bus_mmc1", "bus_mmc2",
> +                                            "bus_nand", "bus_sdram", "bus_emac",
> +                                            "bus_hstimer", "bus_spi0",
> +                                            "bus_spi1", "bus_usb_otg",
> +                                            "bus_ehci0", "bus_ehci1",
> +                                            "bus_ohci0", "bus_ve",
> +                                            "bus_lcd0", "bus_lcd1",
> +                                            "bus_csi", "bus_hdmi",
> +                                            "bus_de", "bus_gpu", "bus_msgbox",
> +                                            "bus_spinlock", "bus_spidf",

"spdif". See https://en.wikipedia.org/wiki/S/PDIF

> +                                            "bus_pio", "bus_i2s0", "bus_i2s1",
> +                                            "bus_i2s2", "bus_tdm", "bus_i2c0",
> +                                            "bus_i2c1", "bus_i2c2",
> +                                            "bus_uart0", "bus_uart1",
> +                                            "bus_uart2", "bus_uart3",
> +                                            "bus_uart4";
> +               };
>         };
>
>         soc {
> @@ -160,7 +251,7 @@
>                                      <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>,
>                                      <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
>                         reg = <0x01c20800 0x400>;
> -                       clocks = <&osc24M>;
> +                       clocks = <&bus_gates 69>;
>                         gpio-controller;
>                         interrupt-controller;
>                         #interrupt-cells = <3>;
> @@ -189,12 +280,31 @@
>                         };
>                 };
>
> +               ahb_reset: reset@01c202c0 {
> +                       reg = <0x01c202c0 0xc>;
> +                       compatible = "allwinner,sun6i-a31-clock-reset";
> +                       #reset-cells = <1>;
> +               };
> +
> +               apb1_reset: reset@01c202d0 {
> +                       reg = <0x01c202d0 0x4>;
> +                       compatible = "allwinner,sun6i-a31-clock-reset";
> +                       #reset-cells = <1>;
> +               };
> +
> +               apb2_reset: reset@01c202d8 {
> +                       reg = <0x01c202d8 0x4>;
> +                       compatible = "allwinner,sun6i-a31-clock-reset";
> +                       #reset-cells = <1>;
> +               };
> +
>                 timer@01c20c00 {
>                         compatible = "allwinner,sun4i-a10-timer";
>                         reg = <0x01c20c00 0xa0>;
>                         interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>,
>                                      <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> -                       clocks = <&osc24M>;
> +                       clocks = <&bus_gates 112>;
> +                       resets = <&apb2_reset 16>;

These 2 were in uart0 in v1. Clearly something went wrong.

ChenYu

>                 };
>
>                 watchdog@01c20ca0 {
> --
> 1.9.1
>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 00/13]  Add A83T clk, r_pio, mmc rsb support Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-28 16:20 +0100
  [PATCH v2 01/13] pinctrl: sunxi: Add A83T R_PIO controller support Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-28 16:20 +0100
    Re: [PATCH v2 01/13] pinctrl: sunxi: Add A83T R_PIO controller  support Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-03-01 08:10 +0100
  [PATCH v2 04/13] ARM: dts: sun8i-a83t: Add basic clocks and resets Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-28 16:20 +0100
    Re: [PATCH v2 04/13] ARM: dts: sun8i-a83t: Add basic clocks and resets Chen-Yu Tsai <wens@csie.org> - 2016-02-28 18:30 +0100
      Re: [PATCH v2 04/13] ARM: dts: sun8i-a83t: Add basic clocks and resets Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-29 15:50 +0100
  [PATCH v2 05/13] ARM: dts: sun8i-a83t: add mmc clock nodes Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-28 16:20 +0100
  [PATCH v2 02/13] clk: sunxi: add ahb1 clock for A83T Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-28 16:20 +0100
    Re: [PATCH v2 02/13] clk: sunxi: add ahb1 clock for A83T Chen-Yu Tsai <wens@csie.org> - 2016-02-29 05:20 +0100
  [PATCH v2 06/13] ARM: dts: sun8i-a83t: Add mmc controller nodes Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-28 16:20 +0100
  [PATCH v2 03/13] clk: sunxi: Add APB1 clock for A83T Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-28 16:20 +0100
  [PATCH v2 08/13] ARM: dts: sun8i-a83t: Add R_PIO controller node to the dtsi Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-28 16:30 +0100
  [PATCH v2 11/13] ARM: dts: sun8i: enable mmc for H8Homlet Board. Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-28 16:30 +0100
  [PATCH v2 10/13] ARM: dts: sun8i-a83t: add mmc0 CD pin Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-28 16:30 +0100
  [PATCH v2 09/13] ARM: dts: sun8i-a83t: Add RSB controller device node to dtsi Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-28 16:30 +0100
  [PATCH v2 07/13] ARM: dts: sun8i-a83t: Add PRCM related clocks and resets Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-28 16:30 +0100
  [PATCH v2 12/13] ARM: dts: sun8i: Add A83T based Sinovoip Bpi-M3 Board Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-28 16:30 +0100
  [PATCH v2 13/13] ARM: sunxi: Introduce MACH_SUN8I_A83T option Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-02-28 16:30 +0100
    Re: [PATCH v2 13/13] ARM: sunxi: Introduce MACH_SUN8I_A83T option Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-03-01 08:20 +0100
      Re: [PATCH v2 13/13] ARM: sunxi: Introduce MACH_SUN8I_A83T option Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-03-02 17:10 +0100

csiph-web