Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1345334
| From | Maarten ter Huurne <maarten@treewalker.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/7] regulator: act8865: Remove redundant dev lookups |
| Date | 2016-02-28 17:00 +0100 |
| Message-ID | <r7bVh-4Ib-19@gated-at.bofh.it> (permalink) |
| References | <r7bVf-4Ib-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The local variable "dev" already contains a pointer to the device,
so there is no need to take the address of "client->dev" again.
Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>
---
drivers/regulator/act8865-regulator.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c
index 7bdb844..0e2d3f5 100644
--- a/drivers/regulator/act8865-regulator.c
+++ b/drivers/regulator/act8865-regulator.c
@@ -557,8 +557,7 @@ static int act8865_pmic_probe(struct i2c_client *client,
act8865->regmap = devm_regmap_init_i2c(client, ®map_config);
if (IS_ERR(act8865->regmap)) {
ret = PTR_ERR(act8865->regmap);
- dev_err(&client->dev, "Failed to allocate register map: %d\n",
- ret);
+ dev_err(dev, "Failed to allocate register map: %d\n", ret);
return ret;
}
@@ -585,7 +584,7 @@ static int act8865_pmic_probe(struct i2c_client *client,
config.driver_data = act8865;
config.regmap = act8865->regmap;
- rdev = devm_regulator_register(&client->dev, desc, &config);
+ rdev = devm_regulator_register(dev, desc, &config);
if (IS_ERR(rdev)) {
dev_err(dev, "failed to register %s\n", desc->name);
return PTR_ERR(rdev);
--
2.6.2
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/7] regulator: act8865: Expose act8600 registers via debugfs Maarten ter Huurne <maarten@treewalker.org> - 2016-02-28 17:00 +0100 [PATCH 4/7] regulator: act8865: Rename platform_data field to init_data Maarten ter Huurne <maarten@treewalker.org> - 2016-02-28 17:00 +0100 [PATCH 2/7] regulator: act8865: Remove redundant dev lookups Maarten ter Huurne <maarten@treewalker.org> - 2016-02-28 17:00 +0100 Re: [PATCH 1/7] regulator: act8865: Expose act8600 registers via debugfs Mark Brown <broonie@kernel.org> - 2016-02-29 12:30 +0100
csiph-web