[PATCH] dma-debug: Avoid NULL dereference when checking sync

From	Maarten ter Huurne <maarten@treewalker.org>
Newsgroups	linux.kernel
Subject	[PATCH] dma-debug: Avoid NULL dereference when checking sync
Date	2016-02-28 16:40 +0100
Message-ID	<r7bBU-4yM-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

check_sync() calls bucket_find_contain(), which in turn calls
dma_get_max_seg_size(), which dereferences the device pointer.

Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>
---
 lib/dma-debug.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index 4a1515f..4960402 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -1194,6 +1194,13 @@ static void check_sync(struct device *dev,
 	struct hash_bucket *bucket;
 	unsigned long flags;
 
+	if (!ref->dev) {
+		err_printk(dev, NULL, "DMA-API: device driver passes NULL "
+				"for device to DMA sync function; "
+				"cannot check usage\n");
+		return;
+	}
+
 	bucket = get_hash_bucket(ref, &flags);
 
 	entry = bucket_find_contain(&bucket, ref, &flags);
-- 
2.6.2

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] dma-debug: Avoid NULL dereference when checking sync Maarten ter Huurne <maarten@treewalker.org> - 2016-02-28 16:40 +0100

csiph-web