Re: [PATCH] i2c-thunderx: fix compile error for x86_64

From	David Daney <ddaney@caviumnetworks.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] i2c-thunderx: fix compile error for x86_64
Date	2016-03-01 18:10 +0100
Message-ID	<r7VY6-3zV-13@gated-at.bofh.it> (permalink)
References	<r7wn0-3Hf-25@gated-at.bofh.it> <r7T0e-1s3-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/01/2016 05:53 AM, Jan Glauber wrote:
> The i2c-thunderx driver only depends on 64BIT and PCI,
> because there is no reason to limit it to ARM64.
>
> Adjusting the check in the header file that selects Octeon
> or ThunderX values to check for CONFIG_I2C_THUNDERX
> instead of CONFIG_ARCH_THUNDER fixes the compile error
> on x86_64.
>
> Signed-off-by: Jan Glauber <jglauber@cavium.com>

Yes, CONFIG_ARCH_THUNDER must die wherever it is encountered.

Acked-by: David Daney <david.daney@cavium.com>

That said, since the previous patch set didn't build under some 
configurations, can you fold this in, and submit a v2 that is complete 
and stand alone?

Thanks,
David Daney

> ---
>   drivers/i2c/busses/i2c-cavium.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-cavium.h b/drivers/i2c/busses/i2c-cavium.h
> index 8357997..c7398f4 100644
> --- a/drivers/i2c/busses/i2c-cavium.h
> +++ b/drivers/i2c/busses/i2c-cavium.h
> @@ -8,7 +8,7 @@
>   #include <linux/pci.h>
>
>   /* Register offsets */
> -#ifdef CONFIG_ARCH_THUNDER
> +#ifdef CONFIG_I2C_THUNDERX
>   	#define SW_TWSI			0x1000
>   	#define TWSI_INT		0x1010
>   	#define SW_TWSI_EXT		0x1018
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] i2c-thunderx: fix compile error for x86_64 Jan Glauber <jglauber@cavium.com> - 2016-03-01 15:00 +0100
  Re: [PATCH] i2c-thunderx: fix compile error for x86_64 David Daney <ddaney@caviumnetworks.com> - 2016-03-01 18:10 +0100

csiph-web