Re: [PATCH] staging: rtl8723au: Fix line longer than 80 columns.

From	Edward Lipinsky <ellipinsky@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: rtl8723au: Fix line longer than 80 columns.
Date	2016-03-01 18:00 +0100
Message-ID	<r7VOq-3gD-21@gated-at.bofh.it> (permalink)
References	<r6RMR-73z-15@gated-at.bofh.it> <r6S6e-7aw-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Feb 27, 2016 at 10:48:56AM -0800, Joe Perches wrote:
> On Sat, 2016-02-27 at 10:28 -0800, Edward Lipinsky wrote:
> > This patch fixes the checkpatch.pl warning:
> > WARNING: line over 80 characters
> []
> > diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> []
> > @@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter)
> >  	}
> >  	spin_unlock_bh(&pacl_node_q->lock);
> >  
> > -	DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num);
> > +	DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__,
> > +		  pacl_list->num);
> 
> It's generally nicer to break the line at the end
> of the format sting like:
> 
> 	DBG_8723A("%s, free acl_node_queue, num =%d\n",
> 		  __func__, pacl_list->num);
> 
> though it'd be even better to convert all of these
> DBG_8723A uses to pr_debug
> 
> $ git ls-files drivers/staging/rtl8723au/ |	\
>   xargs sed -r -i				\
> 	-e 's/\bDBG_8723A\b/pr_debug/g'		\
>  	-e 's/\bMSG|8723A\b/pr_debug/g'
> 

Thanks for the feedback.  I will submit an updated patch.

Ed

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8723au: Fix line longer than 80 columns. Edward Lipinsky <ellipinsky@gmail.com> - 2016-02-27 19:30 +0100
  Re: [PATCH] staging: rtl8723au: Fix line longer than 80 columns. Joe Perches <joe@perches.com> - 2016-02-27 19:50 +0100
    Re: [PATCH] staging: rtl8723au: Fix line longer than 80 columns. Edward Lipinsky <ellipinsky@gmail.com> - 2016-03-01 18:00 +0100

csiph-web