Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1346461

Re: [PATCH v2 4/4] drivers: dma-coherent: use memset_io for DMA_MEMORY_IO mappings

Show all headers | View raw

Hi Andrew,

On Mon, Feb 29, 2016 at 03:17:49PM -0800, Andrew Morton wrote:
>On Mon, 29 Feb 2016 16:09:24 +0000 Brian Starkey <brian.starkey@arm.com> wrote:
>
>> Use memset_io() for DMA_MEMORY_IO mappings which are mapped as I/O
>> memory, and regular memset() for DMA_MEMORY_MAP mappings.
>>
>> This fixes the below alignment fault on arm64 for DMA_MEMORY_IO
>> mappings, where memset() uses the DC ZVA instruction which is
>> invalid on device memory.
>
>What's the urgency of this fix?  "Hair on fire needed in stable asap"
>or "Nice to have in there for 4.6" or what?
>

No-one else is complaining so probably not the former. If it could
make 4.6 though that would be grand.

As for stable, anything before 3.15 doesn't hit the fault (on arm64)
because memset() is different, so probably not needed there.
For anything after that this patch in isolation isn't a full fix,
because dma_init_coherent_memory() will still use the wrong mapping
function for DMA_MEMORY_MAP. In that case, I think it needs to be the
whole series or nothing. I don't have a strong opinion either way, but
perhaps someone else does.

Thanks
Brian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] Fix kernel panic in dma-coherent allocations Brian Starkey <brian.starkey@arm.com> - 2016-02-29 17:10 +0100
  [PATCH v2 1/4] memremap: don't modify flags Brian Starkey <brian.starkey@arm.com> - 2016-02-29 17:20 +0100
  [PATCH v2 4/4] drivers: dma-coherent: use memset_io for DMA_MEMORY_IO mappings Brian Starkey <brian.starkey@arm.com> - 2016-02-29 17:20 +0100
    Re: [PATCH v2 4/4] drivers: dma-coherent: use memset_io for  DMA_MEMORY_IO mappings Andrew Morton <akpm@linux-foundation.org> - 2016-03-01 00:20 +0100
      Re: [PATCH v2 4/4] drivers: dma-coherent: use memset_io for  DMA_MEMORY_IO mappings Brian Starkey <brian.starkey@arm.com> - 2016-03-01 10:10 +0100
  [PATCH v2 3/4] drivers: dma-coherent: use MEMREMAP_WC for DMA_MEMORY_MAP Brian Starkey <brian.starkey@arm.com> - 2016-02-29 17:20 +0100
  [PATCH v2 2/4] memremap: add MEMREMAP_WC flag. Brian Starkey <brian.starkey@arm.com> - 2016-02-29 17:20 +0100

csiph-web