Re: [PATCHv7 2/3] IB/core: added support to use rdma cgroup controller

From	Parav Pandit <pandit.parav@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv7 2/3] IB/core: added support to use rdma cgroup controller
Date	2016-03-01 10:30 +0100
Message-ID	<r7OMW-7c9-15@gated-at.bofh.it> (permalink)
References	<r7amt-3B3-3@gated-at.bofh.it> <r7amu-3B3-11@gated-at.bofh.it> <r7OMW-7c9-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 1, 2016 at 2:42 PM, Haggai Eran <haggaie@mellanox.com> wrote:
> On 28/02/2016 16:13, Parav Pandit wrote:
>> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
>> index 00da80e..54ea8ce 100644
>> --- a/drivers/infiniband/core/device.c
>> +++ b/drivers/infiniband/core/device.c
>> @@ -343,28 +343,38 @@ int ib_register_device(struct ib_device *device,
>>
>>       ret = read_port_immutable(device);
>>       if (ret) {
>> -             printk(KERN_WARNING "Couldn't create per port immutable data %s\n",
>> -                    device->name);
>> +             pr_warn("Couldn't create per port immutable data %s\n",
>> +                     device->name);
>>               goto out;
>
> This change doesn't belong in the patch.
I agree, but few warnings are with pr_warn and few with printk just
make code look uneven.
So I changed printk to pr_warn in same function instead of spinning
complete new patch.

Thread

[PATCHv7 2/3] IB/core: added support to use rdma cgroup controller Parav Pandit <pandit.parav@gmail.com> - 2016-02-28 15:20 +0100
  Re: [PATCHv7 2/3] IB/core: added support to use rdma cgroup controller Parav Pandit <pandit.parav@gmail.com> - 2016-03-01 10:30 +0100
    Re: [PATCHv7 2/3] IB/core: added support to use rdma cgroup controller Parav Pandit <pandit.parav@gmail.com> - 2016-03-01 14:50 +0100
  Re: [PATCHv7 2/3] IB/core: added support to use rdma cgroup controller Parav Pandit <pandit.parav@gmail.com> - 2016-03-01 10:30 +0100

csiph-web