Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1346379

Re: [PATCH] ASoC: intel: remove unused variable

Show all headers | View raw

On Tue, Mar 01, 2016 at 11:59:12AM +0900, Mark Brown wrote:
> On Mon, Feb 29, 2016 at 10:53:46PM +0530, Sudip Mukherjee wrote:
> > The variable cmd_id is only assigned some value and is never used.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> 
> Your signoff doesn't correspond to your e-mail address.  While I'm
> fairly sure that you are in fact the same person so it's OK this time
> please try to ensure that they match up so that it's clear that the
> signoffs are all in order.

But it has been like this way since I started contributing.
git log --author=sudip will show you.

From: address was always sudipm.mukherjee@gmail.com
but Signed-off-by: was sudip@vectorindia.org and now
Signed-off-by: has changed to sudip.mukherjee@codethink.co.uk
and you already have many such patches from me. (well, with my
vectorindia.org email)

Can i not keep using my gmail as my From: ?
The advantage of using gmail as my From: is that the discussion and all
threads related to my patches will be in the same place even if my work
email is changed.

And AFAIK, the From: name and the Signed-off-by: name should match else
the tools used by Greg and others to generate the stats will break.

Please reconsider and let me use my gmail in my From:

regards
sudip

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: intel: remove unused variable Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-29 18:30 +0100
  Re: [PATCH] ASoC: intel: remove unused variable Mark Brown <broonie@kernel.org> - 2016-03-01 04:00 +0100
    Re: [PATCH] ASoC: intel: remove unused variable Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-01 06:50 +0100
      Re: [alsa-devel] [PATCH] ASoC: intel: remove unused variable Takashi Iwai <tiwai@suse.de> - 2016-03-01 08:50 +0100
      Re: [PATCH] ASoC: intel: remove unused variable Mark Brown <broonie@kernel.org> - 2016-03-02 02:10 +0100
        Re: [PATCH] ASoC: intel: remove unused variable Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-02 07:30 +0100
          Re: [PATCH] ASoC: intel: remove unused variable Mark Brown <broonie@kernel.org> - 2016-03-02 12:00 +0100
          Re: [PATCH] ASoC: intel: remove unused variable One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-03-02 13:30 +0100
            Re: [PATCH] ASoC: intel: remove unused variable Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-02 14:10 +0100
              Re: [PATCH] ASoC: intel: remove unused variable Mark Brown <broonie@kernel.org> - 2016-03-02 14:50 +0100
            Re: [PATCH] ASoC: intel: remove unused variable Mark Brown <broonie@kernel.org> - 2016-03-02 14:30 +0100
              Re: [PATCH] ASoC: intel: remove unused variable One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-03-02 15:00 +0100
                Re: [PATCH] ASoC: intel: remove unused variable Mark Brown <broonie@kernel.org> - 2016-03-02 15:10 +0100
              Re: [PATCH] ASoC: intel: remove unused variable Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-02 17:10 +0100

csiph-web