Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1346367
| From | Yong Wu <yong.wu@mediatek.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] iommu/mediatek: mark PM functions as __maybe_unused |
| Date | 2016-03-01 06:10 +0100 |
| Message-ID | <r7KJk-4CH-9@gated-at.bofh.it> (permalink) |
| References | <r7sjp-198-13@gated-at.bofh.it> <r7sjp-198-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 2016-02-29 at 10:19 +0100, Arnd Bergmann wrote:
> When CONFIG_PM is unset, we get a harmless warning for this driver:
>
> drivers/iommu/mtk_iommu.c:665:12: error: 'mtk_iommu_suspend' defined but not used [-Werror=unused-function]
> drivers/iommu/mtk_iommu.c:680:12: error: 'mtk_iommu_resume' defined but not used [-Werror=unused-function]
>
> Marking the functions as __maybe_unused gits rid of the two functions
> and lets the compiler silently drop the object code, while still
> doing syntax checking on them for build-time verification.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0df4fabe208d ("iommu/mediatek: Add mt8173 IOMMU driver")
Hi Arnd,
Thanks very much for both fixes.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU Arnd Bergmann <arnd@arndb.de> - 2016-02-29 10:30 +0100
[PATCH 2/2] iommu/mediatek: mark PM functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-02-29 10:30 +0100
Re: [PATCH 2/2] iommu/mediatek: mark PM functions as __maybe_unused Yong Wu <yong.wu@mediatek.com> - 2016-03-01 06:10 +0100
Re: [PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU Robin Murphy <robin.murphy@arm.com> - 2016-02-29 11:40 +0100
Re: [PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU Arnd Bergmann <arnd@arndb.de> - 2016-02-29 12:00 +0100
Re: [PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU Robin Murphy <robin.murphy@arm.com> - 2016-02-29 12:30 +0100
Re: [PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU Arnd Bergmann <arnd@arndb.de> - 2016-02-29 12:40 +0100
Re: [PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU Robin Murphy <robin.murphy@arm.com> - 2016-02-29 12:50 +0100
Re: [PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU Joerg Roedel <joro@8bytes.org> - 2016-02-29 16:50 +0100
csiph-web