Re: [PATCH] x86, pkeys: fix siginfo ABI breakage from new field

From	Stephen Rothwell <sfr@canb.auug.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86, pkeys: fix siginfo ABI breakage from new field
Date	2016-03-01 00:00 +0100
Message-ID	<r7EXg-Ih-33@gated-at.bofh.it> (permalink)
References	(3 earlier) <r6LxL-2kH-1@gated-at.bofh.it> <r6Szf-7Cl-1@gated-at.bofh.it> <r6SSC-7LP-11@gated-at.bofh.it> <r6Wtc-1Rk-3@gated-at.bofh.it> <r7r3X-pZ-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Ingo,

On Mon, 29 Feb 2016 09:01:43 +0100 Ingo Molnar <mingo@kernel.org> wrote:
>
> * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > > u32?  
> > 
> > It would have to be __u32, but we already use int and unsigned int
> > extensively in the siginfo structure (which are both always assumed to
> > be 32 bits).  So "unsigned int" probably makes most sense.  
> 
> No. This whole mishap is an object lesson in why it's a bad idea to ever use ABI 
> types outside of the __[us][8|16|32|64] space: some of them are 'fine', some of 
> them (like longs) are not.

Absolutely. I was just trying to be consistent with the rest of the structure.

Dave has submitted a follow up version which I have Acked.

-- 
Cheers,
Stephen Rothwell

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] x86, pkeys: fix siginfo ABI breakage from new field Dave Hansen <dave@sr71.net> - 2016-02-26 18:40 +0100
  Re: [PATCH] x86, pkeys: fix siginfo ABI breakage from new field "H. Peter Anvin" <hpa@zytor.com> - 2016-02-26 18:50 +0100
    Re: [PATCH] x86, pkeys: fix siginfo ABI breakage from new field Stephen Rothwell <sfr@canb.auug.org.au> - 2016-02-26 23:20 +0100
      Re: [PATCH] x86, pkeys: fix siginfo ABI breakage from new field Ingo Molnar <mingo@kernel.org> - 2016-02-27 12:50 +0100
        Re: [PATCH] x86, pkeys: fix siginfo ABI breakage from new field Dave Hansen <dave@sr71.net> - 2016-02-27 20:20 +0100
          Re: [PATCH] x86, pkeys: fix siginfo ABI breakage from new field "H. Peter Anvin" <hpa@zytor.com> - 2016-02-27 20:40 +0100
            Re: [PATCH] x86, pkeys: fix siginfo ABI breakage from new field Stephen Rothwell <sfr@canb.auug.org.au> - 2016-02-28 00:30 +0100
              [PATCH v2] signals, pkeys: make si_pkey 32 bits Stephen Rothwell <sfr@canb.auug.org.au> - 2016-02-28 00:50 +0100
                Re: [PATCH v2] signals, pkeys: make si_pkey 32 bits Ingo Molnar <mingo@kernel.org> - 2016-02-29 09:00 +0100
              Re: [PATCH] x86, pkeys: fix siginfo ABI breakage from new field Ingo Molnar <mingo@kernel.org> - 2016-02-29 09:10 +0100
                Re: [PATCH] x86, pkeys: fix siginfo ABI breakage from new field Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-01 00:00 +0100

csiph-web