Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1346222
| From | Ben Hutchings <ben@decadent.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings |
| Date | 2016-02-29 23:40 +0100 |
| Message-ID | <r7EDV-zZ-35@gated-at.bofh.it> (permalink) |
| References | <r6bXk-1x8-17@gated-at.bofh.it> <r7EaT-q9-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Mon, 2016-02-29 at 17:09 -0500, David Miller wrote: > From: Simon Xiao <sixiao@microsoft.com> > Date: Thu, 25 Feb 2016 15:24:08 -0800 > > > This patch allows the user to set and retrieve speed and duplex of the > > hv_netvsc device via ethtool. > > > > Example: > > $ ethtool eth0 > > Settings for eth0: > > ... > > Speed: Unknown! > > Duplex: Unknown! (255) > > ... > > $ ethtool -s eth0 speed 1000 duplex full > > $ ethtool eth0 > > Settings for eth0: > > ... > > Speed: 1000Mb/s > > Duplex: Full > > ... > > > > This is based on patches by Roopa Prabhu and Nikolay Aleksandrov. > > > > Signed-off-by: Simon Xiao <sixiao@microsoft.com> > > Applied, thanks. I missed this due to flu, but now I look at it - I don't see the point. Link speed isn't meaingful for a memory-based transport, so "unknown" is correct. The link is effectively full duplex though. If the issue is that ethtool is a bit shouty about unknowns, let's consider changing that in ethtool, not teaching drivers to lie. Ben. -- Ben Hutchings If God had intended Man to program, we'd have been born with serial I/O ports.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next] hv_netvsc: add ethtool support for set and get of settings Simon Xiao <sixiao@microsoft.com> - 2016-02-25 22:50 +0100
Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings David Miller <davem@davemloft.net> - 2016-02-29 23:10 +0100
Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings Ben Hutchings <ben@decadent.org.uk> - 2016-02-29 23:40 +0100
Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings David Miller <davem@davemloft.net> - 2016-03-01 00:00 +0100
Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings Ben Hutchings <ben@decadent.org.uk> - 2016-03-01 16:40 +0100
csiph-web