Re: [PATCH] mm: memcontrol: reset memory.low on css offline

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: memcontrol: reset memory.low on css offline
Date	2016-02-29 22:00 +0100
Message-ID	<r7D58-7Z4-5@gated-at.bofh.it> (permalink)
References	<r7zEe-5WZ-9@gated-at.bofh.it> <r7CiJ-7H6-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Mon, Feb 29, 2016 at 03:02:55PM -0500, Johannes Weiner wrote:
> > To fix this, let's reset memory.low on css offline.
> 
> We already have mem_cgroup_css_reset() for soft-offlining a css - when
> the css is asked to be disabled but another subsystem still uses it.
> Can we just call that function during offline as well? The css can be
> around for quite a bit after the user deleted it. Eliminating *any*
> user-supplied configurations and zapping it back to defaults makes
> sense in general, so that we never have to worry about any remnants.

Hmmm... I wonder whether the behavior can be a bit surprising and it
could be better to simply let memcg offline callback to call the reset
function explicitly.  No big deal either way tho.  Please feel free to
send a patch.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm: memcontrol: reset memory.low on css offline Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-02-29 18:20 +0100
  Re: [PATCH] mm: memcontrol: reset memory.low on css offline Michal Hocko <mhocko@kernel.org> - 2016-02-29 19:30 +0100
  Re: [PATCH] mm: memcontrol: reset memory.low on css offline Johannes Weiner <hannes@cmpxchg.org> - 2016-02-29 21:10 +0100
    Re: [PATCH] mm: memcontrol: reset memory.low on css offline Tejun Heo <tj@kernel.org> - 2016-02-29 22:00 +0100

csiph-web