Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1346062
| From | Oleg Nesterov <oleg@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mm, proc: make clear_refs killable |
| Date | 2016-02-29 19:20 +0100 |
| Message-ID | <r7AAh-6wh-1@gated-at.bofh.it> (permalink) |
| References | <r7w3E-3yu-9@gated-at.bofh.it> <r7AqC-6t8-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 02/29, Michal Hocko wrote:
>
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -1027,11 +1027,15 @@ static ssize_t clear_refs_write(struct file *file, const char __user *buf,
> };
>
> if (type == CLEAR_REFS_MM_HIWATER_RSS) {
> + if (down_write_killable(&mm->mmap_sem)) {
> + count = -EINTR;
> + goto out_mm;
> + }
> +
We do not even need to change count, userspace won't see it anyway. But I agree
it look more clean this way.
I believe the patch is fine.
Oleg.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 07/18] mm, proc: make clear_refs killable Michal Hocko <mhocko@kernel.org> - 2016-02-29 14:30 +0100
Re: [PATCH 07/18] mm, proc: make clear_refs killable kbuild test robot <lkp@intel.com> - 2016-02-29 14:50 +0100
Re: [PATCH 07/18] mm, proc: make clear_refs killable Oleg Nesterov <oleg@redhat.com> - 2016-02-29 18:40 +0100
Re: [PATCH 07/18] mm, proc: make clear_refs killable Michal Hocko <mhocko@kernel.org> - 2016-02-29 19:00 +0100
Re: [PATCH 07/18] mm, proc: make clear_refs killable Oleg Nesterov <oleg@redhat.com> - 2016-02-29 19:00 +0100
Re: [PATCH 07/18] mm, proc: make clear_refs killable Michal Hocko <mhocko@kernel.org> - 2016-02-29 19:10 +0100
[PATCH] mm, proc: make clear_refs killable Michal Hocko <mhocko@kernel.org> - 2016-02-29 19:10 +0100
Re: [PATCH] mm, proc: make clear_refs killable Oleg Nesterov <oleg@redhat.com> - 2016-02-29 19:20 +0100
Re: [PATCH] mm, proc: make clear_refs killable kbuild test robot <lkp@intel.com> - 2016-02-29 21:30 +0100
csiph-web