Re: [PATCH v3] staging: octeon: Convert create_singlethread_workqueue()

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] staging: octeon: Convert create_singlethread_workqueue()
Date	Sun, 28 Feb 2016 14:20:02 +0100
Message-ID	<r79qq-2OC-15@gated-at.bofh.it> (permalink)
References	<r6RjQ-6Df-1@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UlXvhwqYZ9qE36VBcRNEKL2ulSMctSeWZ9Ex00CFSjM=; b=IyGAUfpNWu+K5MHn+LLPYlonzR5Yh1BsDVjYhqSec34WN/NHG3/7+eRmD67GjbhmPH z18cQcuN6/ksFtwIordY9rjiQoEfbDb9Lag9z3aVtZEZ3Pj2MydzUgChN5Wy+/wWM2cr 2JKcb8uNbQZ3kpITmjn2ePkdhRdQew/EF72V7q9o2A99/5ks0uW+7y+1UuLeb+yE3cAX R7rVTkfdvw3DYF7rVVofcudVfbAjqPA1FNVXybDcBBYESL8JGItyAfGIaPJ6kRA9jgJa NgWijiVOWcpOxhXIXLTrVjrDI6Aq+OIi0L2RrMs9UuNQDanuOXQPQulEVZsO4tYIEXUJ J15w==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=UlXvhwqYZ9qE36VBcRNEKL2ulSMctSeWZ9Ex00CFSjM=; b=LX4cihijx+NwB8B76EY4KYG0i9FBTckFHqdgt0VMO3NCK/iW/Mgrn54IJF1/kRBUgo r0TPtZc3yStemks0VMKHyvMohoaumTnrgnf7lmTEFpa0S/yiBR36pNlToSmgr5aHgj2O XWcOppnM0Vq5uuXXB+HMHFDr/mtOtWGC/9HDbvKxPFDhtzkEaPOBzdmgYSKQwaYP+QHC IIb11mb+mIXqdNOrpEK7O65IMQvojZThKpd24fSw1+gNF3PBMwmrE8m6VZ2FCXxvsdYD ILV5+BuQAmPo4hDow9byOLCaxlrJrAqTs+rLQdYeInMWyOee6pYJIVB44Gzu/isB6SYc GOkQ==
X-Gm-Message-State	AD7BkJKpgk9xK57NIch224ruy2gMyfhWhbi2YNws71+UZEcpIeD6gZrAYDAYPaYa4KOMFA==
X-Received	by 10.182.33.101 with SMTP id q5mr7950837obi.28.1456664991720; Sun, 28 Feb 2016 05:09:51 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	gregkh@linuxfoundation.org, aaro.koskinen@iki.fi, cristina.moraru09@gmail.com, avid.daney@cavium.com, david.daney@cavium.com, ralf@linux-mips.org, paul.martin@codethink.co.uk, arnd@arndb.de, joe@perches.com, aybuke.147@gmail.com, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
X-Original-Date	Sun, 28 Feb 2016 08:09:50 -0500
X-Original-Message-ID	<20160228130950.GJ3965@htj.duckdns.org>
X-Original-References	<20160227175147.GA28115@Karyakshetra>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1345246

Show key headers only | View raw

Hello,

On Sat, Feb 27, 2016 at 11:21:47PM +0530, Bhaktipriya Shridhar wrote:
> With conccurency managed workqueues, use of dedicated workqueues can
> be replaced by system_wq. Drop cvm_oct_poll_queue by using system_wq.
> 
> There are multiple work items per cvm_oct_poll_queue (viz.
> cvm_oct_rx_refill_work, port_periodic_work) and different
> cvm_oct_poll_queues need not be be ordered. Hence, concurrency
> can be increased by switching to system_wq.
> 
> All work items are sync canceled in cvm_oct_remove() so it
> is guaranteed that no work is in flight by the time exit path runs.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

For the workqueue part,

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] staging: octeon: Convert create_singlethread_workqueue() Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-02-27 19:00 +0100
  Re: [PATCH v3] staging: octeon: Convert  create_singlethread_workqueue() Tejun Heo <tj@kernel.org> - 2016-02-28 14:20 +0100

csiph-web