Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1345249

Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles

Show all headers | View raw

On Sun, Feb 28, 2016 at 08:21:40AM +0800, Chen Gang wrote:
> 
> On 2/28/16 00:53, Theodore Ts'o wrote:
> > On Sat, Feb 27, 2016 at 10:32:04PM +0800, Chen Gang wrote:
> >> I don't think so. Of cause NOT the "CODE CHURN". It is not correct to
> >> make an early decision during discussing.
> > 
> > There is no discussion.  If the maintainer has NAK'ed it.  That's the
> > end of the dicsussion.  Period.  See:
> > 
> 
> For me, NAK also needs reasons.
> 

You already got the reasons. Not only does a patch of this type interfere
with git blame which is important even in headers but I do not think the
patch actually improves the readability of the code. For example, the
comments move to the line after the defintions which to my eye at least
looks clumsy and weird.

> I guess they are related with this patch, and their NAKs' reason are: mm
> and trivial don't care about this coding style issue, is it correct?
> 

No. Coding style is important but it's a guideline not a law. There are
cases where breaking it results in perfectly readable code. At least one
my my own recent patches was flagged by checkpatch as having style issues
but fixing the style was considerably harder to read so I left it. If the
definitions in that header need to change again in the future and there
are style issues then they can be fixed in the context of a functional
change instead of patching style just for the sake of it.

-- 
Mel Gorman
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH trivial] include/linux/gfp.h: Improve the coding styles chengang@emindsoft.com.cn - 2016-02-24 23:30 +0100
  Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles SeongJae Park <sj38.park@gmail.com> - 2016-02-25 02:10 +0100
    Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Chen Gang <chengang@emindsoft.com.cn> - 2016-02-25 15:10 +0100
  Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Michal Hocko <mhocko@kernel.org> - 2016-02-25 10:00 +0100
    Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Chen Gang <chengang@emindsoft.com.cn> - 2016-02-25 15:30 +0100
      Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Michal Hocko <mhocko@kernel.org> - 2016-02-25 15:50 +0100
        Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Chen Gang <chengang@emindsoft.com.cn> - 2016-02-25 23:20 +0100
  Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Mel Gorman <mgorman@techsingularity.net> - 2016-02-25 10:30 +0100
    Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Chen Gang <chengang@emindsoft.com.cn> - 2016-02-25 15:40 +0100
      Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Jiri Kosina <jikos@kernel.org> - 2016-02-25 16:20 +0100
        Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Chen Gang <chengang@emindsoft.com.cn> - 2016-02-25 23:20 +0100
      Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Mel Gorman <mgorman@techsingularity.net> - 2016-02-25 17:10 +0100
        Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Chen Gang <chengang@emindsoft.com.cn> - 2016-02-25 23:30 +0100
          Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Jiri Kosina <jikos@kernel.org> - 2016-02-25 23:40 +0100
            Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Chen Gang <chengang@emindsoft.com.cn> - 2016-02-26 16:00 +0100
          Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles SeongJae Park <sj38.park@gmail.com> - 2016-02-26 00:20 +0100
            Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Chen Gang <chengang@emindsoft.com.cn> - 2016-02-26 16:10 +0100
          Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Jianyu Zhan <nasa4836@gmail.com> - 2016-02-26 03:40 +0100
            Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Chen Gang <chengang@emindsoft.com.cn> - 2016-02-26 16:30 +0100
              Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Theodore Ts'o <tytso@mit.edu> - 2016-02-27 03:50 +0100
                Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Chen Gang <chengang@emindsoft.com.cn> - 2016-02-27 15:30 +0100
                Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Theodore Ts'o <tytso@mit.edu> - 2016-02-27 18:00 +0100
                Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Chen Gang <chengang@emindsoft.com.cn> - 2016-02-28 01:20 +0100
                Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Mel Gorman <mgorman@techsingularity.net> - 2016-02-28 14:30 +0100
                Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Chen Gang <chengang@emindsoft.com.cn> - 2016-02-28 16:30 +0100
                Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Jiri Kosina <jikos@kernel.org> - 2016-02-28 00:20 +0100
                Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Chen Gang <chengang@emindsoft.com.cn> - 2016-02-28 01:50 +0100
                Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Theodore Ts'o <tytso@mit.edu> - 2016-02-28 23:30 +0100
                Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles Chen Gang <chengang@emindsoft.com.cn> - 2016-02-29 18:50 +0100

csiph-web