Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1345216

Re: [PATCH] configfs: switch ->default groups to a linked list

Show all headers | View raw

On 26/02/2016 14:33, Christoph Hellwig wrote:
> Replace the current NULL-terminated array of default groups with a linked
> list.  This gets rid of lots of nasty code to size and/or dynamically
> allocate the array.
>
> While we're at it also provide a conveniant helper to remove the default
> groups.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---

Nice!

> -As a consequence of this, default_groups cannot be removed directly via
> +As a consequence of this, default groups cannot be removed directly via
>   rmdir(2).  They also are not considered when rmdir(2) on the parent
>   group is checking for children.
>

What's changed here?

Other than that, looks good

Reviewed-by: Sagi Grimberg <sagig@mellanox.com>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] configfs: switch ->default groups to a linked list Sagi Grimberg <sagig@dev.mellanox.co.il> - 2016-02-28 12:00 +0100
  Re: [PATCH] configfs: switch ->default groups to a linked list Christoph Hellwig <hch@lst.de> - 2016-02-28 14:10 +0100

csiph-web