Re: [net-next][PATCH v2 11/13] RDS: IB: add Fastreg MR (FRMR) detection support

Path	csiph.com!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [net-next][PATCH v2 11/13] RDS: IB: add Fastreg MR (FRMR) detection support
Date	Sun, 28 Feb 2016 10:10:01 +0100
Message-ID	<r75wt-5M-9@gated-at.bofh.it> (permalink)
References	<r6Zhn-3WL-3@gated-at.bofh.it> <r6Zho-3WL-23@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
X-Srs-Rewrite	SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	22
Organization	linux.* mail to news gateway
X-Original-Cc	netdev@vger.kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org
X-Original-Date	Sun, 28 Feb 2016 01:08:58 -0800
X-Original-Message-ID	<20160228090858.GB6671@infradead.org>
X-Original-References	<1456625990-4739-1-git-send-email-santosh.shilimkar@oracle.com> <1456625990-4739-12-git-send-email-santosh.shilimkar@oracle.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1345193

Show key headers only | View raw

On Sat, Feb 27, 2016 at 06:19:48PM -0800, Santosh Shilimkar wrote:
> Discovere Fast Memmory Registration support using IB device
> IB_DEVICE_MEM_MGT_EXTENSIONS. Certain HCA might support just FRMR
> or FMR or both FMR and FRWR. In case both mr type are supported,
> default FMR is used.
> 
> Default MR is still kept as FMR against what everyone else
> is following. Default will be changed to FRMR once the
> RDS performance with FRMR is comparable with FMR. The
> work is in progress for the same.
> 
> Signed-off-by: Santosh Shilimkar <ssantosh@kernel.org>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
> ---
> v2: Dropped the module parameter as suggested by David Miller

This means we only use the safer method if the HCA doesn't support
the other one.  All other RDMA ULP that support both methods have
a module_param so the veto from Dave is a bit unfortunate.  Anyway,
let's get the code in for now and figure out what to use later.

Just curious:  where / how do you see worse peformance using FRs?

Thread

[net-next][PATCH v2 00/13] RDS: Major clean-up with couple of new features for 4.6 Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-02-28 03:30 +0100
  [net-next][PATCH v2 12/13] RDS: IB: allocate extra space on queues for FRMR support Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-02-28 03:30 +0100
  [net-next][PATCH v2 09/13] RDS: IB: handle the RDMA CM time wait event Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-02-28 03:30 +0100
  [net-next][PATCH v2 04/13] RDS: IB: Remove the RDS_IB_SEND_OP dependency Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-02-28 03:30 +0100
  [net-next][PATCH v2 10/13] RDS: IB: add mr reused stats Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-02-28 03:30 +0100
  [net-next][PATCH v2 11/13] RDS: IB: add Fastreg MR (FRMR) detection support Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-02-28 03:30 +0100
    Re: [net-next][PATCH v2 11/13] RDS: IB: add Fastreg MR (FRMR)  detection support Christoph Hellwig <hch@infradead.org> - 2016-02-28 10:10 +0100
      Re: [net-next][PATCH v2 11/13] RDS: IB: add Fastreg MR (FRMR)  detection support "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> - 2016-02-28 11:30 +0100
  [net-next][PATCH v2 02/13] RDS: Add support for SO_TIMESTAMP for incoming messages Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-02-28 03:30 +0100
  [net-next][PATCH v2 05/13] RDS: IB: Re-organise ibmr code Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-02-28 03:30 +0100
  [net-next][PATCH v2 03/13] MAINTAINERS: update RDS entry Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-02-28 03:30 +0100
  [net-next][PATCH v2 08/13] RDS: IB: add connection info to ibmr Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-02-28 03:30 +0100
  [net-next][PATCH v2 13/13] RDS: IB: Support Fastreg MR (FRMR) memory registration mode Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-02-28 03:30 +0100
  Re: [net-next][PATCH v2 00/13] RDS: Major clean-up with couple of  new features for 4.6 David Miller <davem@davemloft.net> - 2016-03-01 23:40 +0100
    Re: [net-next][PATCH v2 00/13] RDS: Major clean-up with couple of new  features for 4.6 santosh shilimkar <santosh.shilimkar@oracle.com> - 2016-03-02 00:10 +0100

csiph-web