Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1345176

Re: [PATCH v18 0/9] Compile-time stack metadata validation

Show all headers | View raw

FYI, I got this build failure on allmodconfig-x86-64:

  objtool.c:134:1: error: control reaches end of non-void function [-Werror=return-type]

that was with:

  gcc version 4.8.3 20140911 (Red Hat 4.8.3-7) (GCC) 

GCC 5.2.1 does not trigger this warning, which is I suspect why you have not seen 
this in your own testing.

I applied the fix below: all paths that generate a nonzero error do an explicit 
exit(), so return 0 is fine here.

Thanks,

	Ingo

=====================>

 tools/objtool/objtool.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/objtool/objtool.c b/tools/objtool/objtool.c
index 4e53d272c0c3..46c326db4f46 100644
--- a/tools/objtool/objtool.c
+++ b/tools/objtool/objtool.c
@@ -131,4 +131,6 @@ int main(int argc, const char **argv)
 		cmd_usage();
 
 	handle_internal_command(argc, argv);
+
+	return 0;
 }

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v18 0/9] Compile-time stack metadata validation Josh Poimboeuf <jpoimboe@redhat.com> - 2016-02-26 00:00 +0100
  [PATCH v18 3/9] x86/xen: Mark xen_cpuid() stack frame as non-standard Josh Poimboeuf <jpoimboe@redhat.com> - 2016-02-26 00:00 +0100
  [PATCH v18 2/9] objtool: Add STACK_FRAME_NON_STANDARD macro Josh Poimboeuf <jpoimboe@redhat.com> - 2016-02-26 00:00 +0100
  [PATCH v18 4/9] bpf: Mark __bpf_prog_run() stack frame as non-standard Josh Poimboeuf <jpoimboe@redhat.com> - 2016-02-26 00:00 +0100
  [PATCH v18 1/9] objtool: Mark non-standard files and directories Josh Poimboeuf <jpoimboe@redhat.com> - 2016-02-26 00:00 +0100
  [PATCH v18 5/9] sched: Mark __schedule() stack frame as non-standard Josh Poimboeuf <jpoimboe@redhat.com> - 2016-02-26 00:00 +0100
  [PATCH v18 8/9] objtool: Add CONFIG_STACK_VALIDATION option Josh Poimboeuf <jpoimboe@redhat.com> - 2016-02-26 00:00 +0100
  Re: [PATCH v18 0/9] Compile-time stack metadata validation Ingo Molnar <mingo@kernel.org> - 2016-02-28 08:00 +0100
    Re: [PATCH v18 0/9] Compile-time stack metadata validation Josh Poimboeuf <jpoimboe@redhat.com> - 2016-02-28 18:10 +0100
  Re: [PATCH v18 0/9] Compile-time stack metadata validation Ingo Molnar <mingo@kernel.org> - 2016-02-28 08:00 +0100

csiph-web