Re: [PATCH] bsp: add SoC device to brcmstb

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] bsp: add SoC device to brcmstb
Date	2016-02-26 21:40 +0100
Message-ID	<r6xl8-fl-9@gated-at.bofh.it> (permalink)
References	<r6eiu-3m0-25@gated-at.bofh.it> <r6r62-44C-15@gated-at.bofh.it> <r6vt0-7nJ-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Friday 26 February 2016 10:36:27 Florian Fainelli wrote:
> On 26/02/16 05:58, Arnd Bergmann wrote:
> > On Thursday 25 February 2016 16:19:07 Justin Chen wrote:
> >>   */
> >>  void brcmstb_biuctrl_init(void);
> >>  
> >> +/*
> >> + * Helper functions for getting family or product id from the
> >> + * SoC driver.
> >> + */
> >> +u32 brcmstb_get_family_id(void);
> >> +u32 brcmstb_get_product_id(void);
> >> +
> >>  #endif /* __BRCMSTB_SOC_H */
> >> -- 
> > 
> > Please remove the declarations from the header file and make the
> > variable local to this file, to make sure no other driver accidentally
> > accesses them.
> 
> I would remove these two helper functions completely, we do not need
> them right now in an upstream kernel, if we ever need them, we could add
> them back, but we have no use for these two now.

Ok, that sounds even better.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] bsp: add SoC device to brcmstb Justin Chen <justinpopo6@gmail.com> - 2016-02-26 01:20 +0100
  Re: [PATCH] bsp: add SoC device to brcmstb Arnd Bergmann <arnd@arndb.de> - 2016-02-26 15:00 +0100
    Re: [PATCH] bsp: add SoC device to brcmstb Florian Fainelli <f.fainelli@gmail.com> - 2016-02-26 19:40 +0100
      Re: [PATCH] bsp: add SoC device to brcmstb Arnd Bergmann <arnd@arndb.de> - 2016-02-26 21:40 +0100

csiph-web