Re: [PATCH] net: ezchip: adapt driver to little endian architecture

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: ezchip: adapt driver to little endian architecture
Date	2016-02-26 21:30 +0100
Message-ID	<r6xbs-aO-17@gated-at.bofh.it> (permalink)
References	<r6vW1-7QN-7@gated-at.bofh.it> <r6x1M-6H-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 26 Feb 2016 21:10:31 +0100

> On Friday 26 February 2016 22:05:09 Lada Trimasova wrote:
>>                 for (i = 0; i < len; i++, reg++) {
>>                         u32 buf = nps_enet_reg_get(priv, NPS_ENET_REG_RX_BUF);
>> +                       buf = be32_to_cpu(buf);
>>                         put_unaligned(buf, reg);
>>                 }
> 
> I think most of the changes can make use of the put_unaligned_be32()
> etc helpers that might also be more efficient.

Agreed.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: ezchip: adapt driver to little endian architecture Lada Trimasova <Lada.Trimasova@synopsys.com> - 2016-02-26 20:10 +0100
  Re: [PATCH] net: ezchip: adapt driver to little endian architecture Arnd Bergmann <arnd@arndb.de> - 2016-02-26 21:20 +0100
  Re: [PATCH] net: ezchip: adapt driver to little endian architecture Arnd Bergmann <arnd@arndb.de> - 2016-02-26 21:20 +0100
    Re: [PATCH] net: ezchip: adapt driver to little endian architecture David Miller <davem@davemloft.net> - 2016-02-26 21:30 +0100

csiph-web