Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1344606

Re: [PATCH v3] kernel: sched: fix preempt_disable_ip recodring for preempt_disable()

From Daniel Bristot de Oliveira <bristot@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3] kernel: sched: fix preempt_disable_ip recodring for preempt_disable()
Date 2016-02-26 20:20 +0100
Message-ID <r6w5I-7UQ-29@gated-at.bofh.it> (permalink)
References <r1nPr-mX-5@gated-at.bofh.it> <r64VQ-50x-23@gated-at.bofh.it> <r6r62-44C-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On 02/26/2016 10:54 AM, Sebastian Andrzej Siewior wrote:
> -		trace_preempt_off(CALLER_ADDR0, get_parent_ip(CALLER_ADDR1));
> +		trace_preempt_off(CALLER_ADDR0, get_lock_parent_ip());

If !lock_functions(CALLER_ADDR0), the start/stop_critical_timing() will
be called with parent_ip == ip.

Hence, the following trace on start_critical_timing():

        __trace_function(tr, ip, parent_ip, flags, preempt_count());

Will show the function calling itself.

Is it a problem? am I missing something?

-- Daniel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2] kernel: sched: fix preempt_disable_ip recodring for  preempt_disable() Steven Rostedt <rostedt@goodmis.org> - 2016-02-25 15:20 +0100
  [PATCH v3] kernel: sched: fix preempt_disable_ip recodring for  preempt_disable() Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-02-26 15:00 +0100
    Re: [PATCH v3] kernel: sched: fix preempt_disable_ip recodring for  preempt_disable() Daniel Bristot de Oliveira <bristot@redhat.com> - 2016-02-26 20:20 +0100
      Re: [PATCH v3] kernel: sched: fix preempt_disable_ip recodring for  preempt_disable() Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-03-03 14:00 +0100
    [tip:sched/core] sched/debug: Fix preempt_disable_ip recording for  preempt_disable() tip-bot for Sebastian Andrzej Siewior <tipbot@zytor.com> - 2016-02-29 12:30 +0100

csiph-web